Skip to content

Commit

Permalink
Use consistent single quotes in Playwright tests
Browse files Browse the repository at this point in the history
Signed-off-by: Gustavo Lira <guga.java@gmail.com>
  • Loading branch information
gustavolira committed Jan 15, 2025
1 parent b042135 commit 91cf478
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 9 deletions.
16 changes: 8 additions & 8 deletions e2e-tests/playwright/e2e/github-happy-path.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -79,23 +79,23 @@ test.describe.serial('GitHub Happy path', () => {
}
});

test("Click login on the login popup and verify that Overview tab renders", async () => {
await uiHelper.openSidebar("Catalog");
await uiHelper.selectMuiBox("Kind", "Component");
await uiHelper.clickByDataTestId("user-picker-all");
await uiHelper.clickLink("Backstage Showcase");
test('Click login on the login popup and verify that Overview tab renders', async () => {
await uiHelper.openSidebar('Catalog');
await uiHelper.selectMuiBox('Kind', 'Component');
await uiHelper.clickByDataTestId('user-picker-all');
await uiHelper.clickLink('Backstage Showcase');

const expectedPath = "/catalog/default/component/backstage-showcase";
const expectedPath = '/catalog/default/component/backstage-showcase';
// Wait for the expected path in the URL
await page.waitForURL(`**${expectedPath}`, {
waitUntil: "domcontentloaded", // Wait until the DOM is loaded
waitUntil: 'domcontentloaded', // Wait until the DOM is loaded
timeout: 10000,
});
// Optionally, verify that the current URL contains the expected path
await expect(page.url()).toContain(expectedPath);

await common.clickOnGHloginPopup();
await uiHelper.verifyLink("Janus Website", { exact: false });
await uiHelper.verifyLink('Janus Website', { exact: false });
await backstageShowcase.verifyPRStatisticsRendered();
await backstageShowcase.verifyAboutCardIsDisplayed();
});
Expand Down
2 changes: 1 addition & 1 deletion e2e-tests/playwright/support/pages/CatalogImport.ts
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ export class BackstageShowcase {

async verifyAboutCardIsDisplayed() {
const url =
'https://github.com/redhat-developer/rhdh/tree/main/catalog-entities/components/'
'https://github.com/redhat-developer/rhdh/tree/main/catalog-entities/components/';
const isLinkVisible = await this.page
.locator(`a[href="${url}"]`)
.isVisible();
Expand Down

0 comments on commit 91cf478

Please sign in to comment.