Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: githubLoginAsSetup #1797

Closed
wants to merge 42 commits into from
Closed

test: githubLoginAsSetup #1797

wants to merge 42 commits into from

Conversation

nilgaar
Copy link
Contributor

@nilgaar nilgaar commented Oct 21, 2024

Description

Please explain the changes you made here.

Which issue(s) does this PR fix

  • Fixes #?

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 21, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@nilgaar nilgaar force-pushed the e2e/storeGithubAuth branch 5 times, most recently from 34b0d49 to e077c87 Compare October 21, 2024 15:45
@nilgaar
githubLoginAsSetup
5479cb2 
restore 2FA

fix setup project definition

minor fixes

small fixes
@nilgaar nilgaar force-pushed the e2e/storeGithubAuth branch from e077c87 to 5479cb2 Compare October 21, 2024 15:48
@github-actions GitHub Actions
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1797!

@github-actions GitHub Actions
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1797!

@github-actions GitHub Actions
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1797!

@nilgaar nilgaar force-pushed the e2e/storeGithubAuth branch from 406f7ad to 39f3170 Compare October 22, 2024 08:14
@github-actions GitHub Actions
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1797!

@nilgaar nilgaar force-pushed the e2e/storeGithubAuth branch from 13b4fdb to 6f8336c Compare October 22, 2024 09:42
@github-actions GitHub Actions
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1797!

@nilgaar nilgaar force-pushed the e2e/storeGithubAuth branch from 6f8336c to 5f4baa6 Compare October 22, 2024 10:13
@github-actions GitHub Actions
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1797!

@nilgaar nilgaar force-pushed the e2e/storeGithubAuth branch from f46cdfc to 18ee0ff Compare October 22, 2024 11:39
@github-actions GitHub Actions
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1797!

@nilgaar nilgaar reopened this Nov 3, 2024
@nilgaar
Copy link
Contributor Author

nilgaar commented Nov 3, 2024

/test all

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 3, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1797!

@nilgaar
Copy link
Contributor Author

nilgaar commented Nov 3, 2024

/test all

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 3, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1797!

@nilgaar
Copy link
Contributor Author

nilgaar commented Nov 4, 2024

/test e2e-test

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 4, 2024

@nilgaar: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test e2e-tests
  • /test images

Use /test all to run all jobs.

In response to this:

/test e2e-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@nilgaar
Copy link
Contributor Author

nilgaar commented Nov 4, 2024

/test e2e-tests

@nilgaar
Copy link
Contributor Author

nilgaar commented Nov 4, 2024

/test e2e-tests

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 4, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1797!

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 4, 2024

@nilgaar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-tests 1b17fb5 link true /test e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 4, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1797!

@nilgaar nilgaar force-pushed the e2e/storeGithubAuth branch from f7e581a to 5d983cc Compare November 4, 2024 10:41
@nilgaar nilgaar force-pushed the e2e/storeGithubAuth branch from 5d983cc to e91c708 Compare November 4, 2024 10:53
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 4, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from nilgaar. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 4, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1797!

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots

See analysis details on SonarCloud

@nilgaar nilgaar closed this Nov 6, 2024
@nilgaar nilgaar deleted the e2e/storeGithubAuth branch November 6, 2024 12:57
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024

The image is available at:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge/work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nilgaar @openshift-merge-robot