Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(e2e): rhdh deployment on openshift dedicated (osd) on gcp using helm chart #1803

Merged
merged 1 commit into from
Nov 16, 2024
Merged

chore(e2e): rhdh deployment on openshift dedicated (osd) on gcp using helm chart #1803

merged 1 commit into from
Nov 16, 2024

Conversation

subhashkhileri
Copy link
Contributor

@subhashkhileri subhashkhileri commented Oct 22, 2024 •
edited
Loading

Description

  1. Added OSD cluster management scripts (create-osd.sh, destroy-osd.sh)
  2. Updated test infrastructure to use OSD GCP cluster
  3. Added Documentation.

Which issue(s) does this PR fix

RHIDP-4023

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 22, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@subhashkhileri
Copy link
Contributor Author

/test all

@github-actions GitHub Actions
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1803!

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1803!

@subhashkhileri
Copy link
Contributor Author

/test all

@subhashkhileri
Copy link
Contributor Author

/ok-to-test

@subhashkhileri
Copy link
Contributor Author

/test e2e-tests

@github-actions GitHub Actions
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1803!

@subhashkhileri subhashkhileri changed the base branch from main to release-1.3 October 24, 2024 05:48
@subhashkhileri
Copy link
Contributor Author

/test all

@subhashkhileri subhashkhileri changed the base branch from release-1.3 to main October 24, 2024 05:50
@subhashkhileri
Copy link
Contributor Author

/test e2e-tests

@subhashkhileri subhashkhileri changed the title OSD GCP setup chore(e2e) RHDH deployment on OpenShift Dedicated (OSD) on GCP using Helm chart Oct 29, 2024
@subhashkhileri subhashkhileri marked this pull request as ready for review October 29, 2024 12:25
@subhashkhileri subhashkhileri requested a review from a team as a code owner October 29, 2024 12:25
@openshift-ci openshift-ci bot requested review from josephca and zdrapela October 29, 2024 12:25
@subhashkhileri subhashkhileri changed the title chore(e2e) RHDH deployment on OpenShift Dedicated (OSD) on GCP using Helm chart chore(e2e): RHDH deployment on OpenShift Dedicated (OSD) on GCP using Helm chart Oct 29, 2024
@subhashkhileri subhashkhileri changed the title chore(e2e): RHDH deployment on OpenShift Dedicated (OSD) on GCP using Helm chart chore(e2e): rhdh deployment on openshift dedicated (osd) on gcp using helm chart Oct 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1803!

zdrapela
zdrapela reviewed Oct 31, 2024
View reviewed changes
Copy link
Member

@zdrapela zdrapela left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @subhashkhileri, the nightly job for OSD will be set up after we resolve the issue with GitHub login? Or what's the plan? 🙂
Otherwise, it is looking great.

@github-actions GitHub Actions
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1803!

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link
Contributor

The image is available at:

@openshift-ci openshift-ci bot added the lgtm label Nov 14, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gustavolira

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@subhashkhileri
Copy link
Contributor Author

/test e2e-tests

@openshift-merge-bot openshift-merge-bot bot merged commit 2afc8ea into redhat-developer:main Nov 16, 2024
14 checks passed
teknaS47 pushed a commit to teknaS47/backstage-showcase that referenced this pull request Nov 28, 2024
@subhashkhileri @teknaS47
OSD GCP setup (redhat-developer#1803)
3bec211
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zdrapela zdrapela zdrapela left review comments

@gustavolira gustavolira gustavolira approved these changes

@josephca josephca Awaiting requested review from josephca

Assignees

@gustavolira gustavolira

Labels
approved lgtm ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@subhashkhileri @gustavolira @zdrapela @openshift-merge-robot