fix(techdocs): fix ReportIssue style issue when loaded as dynamic plugin [release-1.2] #2031
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
christoph-jerolimov
force-pushed
the
fix-techdocs-addons-1.2
branch
from
358831a to
044e01c
Compare
|
The image is available at: |
Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com>
christoph-jerolimov
force-pushed
the
fix-techdocs-addons-1.2
branch
from
044e01c to
1916be9
Compare
|
|
The image is available at: |
christoph-jerolimov
requested review from
invincibleJai,
divyanshiGupta,
debsmita1 and
ciiay
|
/retest |
|
@christoph-jerolimov: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/override ci/prow/e2e-tests |
|
@christoph-jerolimov: christoph-jerolimov unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
We will not backport it to 1.2 as it's a low severity issue. |
Description
This is a manual backport of #2024 (main) / #2029 (1.4) / #2030 (1.3) because 1.3 and 1.2 has different code style (prettier) rules and requires that the material-ui dependency be mentioned in the techdocs package.json.
1.2 without this PR:
1.2-before.mp4
with this PR (tested on a cluster with pr-2031-1916be94)
1.2-after-1916be94.mp4
Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer
Techdocs is enabled by default.