Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: patch useRedisSets config for cache fix #2061

Merged
merged 1 commit into from
Dec 8, 2024

Conversation

JessicaJHee
Copy link
Contributor

@JessicaJHee JessicaJHee commented Dec 5, 2024

Description

Adds patches for this upstream fix to use the useRedisSets config

  • tested locally after adding the patch and confirmed that the useRedisSets config applies as expected

Fixes: https://issues.redhat.com/browse/RHIDP-5180

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

Signed-off-by: Jessica He <jhe@redhat.com>
@JessicaJHee JessicaJHee requested a review from a team as a code owner December 5, 2024 22:18
Copy link

sonarqubecloud bot commented Dec 5, 2024

Copy link
Contributor

github-actions bot commented Dec 5, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-2061!

@kim-tsao
Copy link
Member

kim-tsao commented Dec 5, 2024

/lgtm
/approve

Copy link

openshift-ci bot commented Dec 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kim-tsao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Dec 5, 2024
@JessicaJHee
Copy link
Contributor Author

/retest

Copy link

openshift-ci bot commented Dec 6, 2024

@JessicaJHee: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-tests 5967522 link true /test e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kim-tsao
Copy link
Member

kim-tsao commented Dec 8, 2024

Manually tested on the DAST instance with a clean install of the PR image

  1. Verified the patch is installed on the RHDH pod
sh-5.1$ cd patches
sh-5.1$ ls
@backstage+backend-defaults+0.4.1.patch                                @backstage+plugin-catalog-backend+1.24.0.patch
  1. Tested with useRedisSets: false and the verified the keys are in the expected format:
redb:10195> KEYS *
1) "sets:namespace:techdocs:techdocs:ZGVmYXVsdC9jb21wb25lbnQvYmFja3N0YWdlLXNob3djYXNlL2luZGV4Lmh0bWw="
2) "sets:namespace:techdocs:techdocs:ZGVmYXVsdC9jb21wb25lbnQvYmFja3N0YWdlLXNob3djYXNlL3NlYXJjaC9zZWFyY2hfaW5kZXguanNvbg=="
3) "sets:namespace:techdocs:techdocs:ZGVmYXVsdC9jb21wb25lbnQvYmFja3N0YWdlLXNob3djYXNlL2Fzc2V0cy9zdHlsZXNoZWV0cy9tYWluLjY1NDNhOTM1Lm1pbi5jc3M="
  1. Tested with useRedisSets:true and verified the keys are in the expected format:
redb:10195> KEYS *
1) "techdocs:D50ujQnjyWz9xLkSXo/VZoriCjGSxSq4o3PRFfGob8Q="
2) "techdocs:ZGVmYXVsdC9jb21wb25lbnQvYmFja3N0YWdlLXNob3djYXNlL3NlYXJjaC9zZWFyY2hfaW5kZXguanNvbg=="
3) "namespace:techdocs"
4) "techdocs:fHXC5tjcQf28DOgphEO46Ctm8+UB7tGZvi7TI4SugtQ="

@kim-tsao kim-tsao merged commit d7bcad2 into redhat-developer:release-1.3 Dec 8, 2024
7 of 9 checks passed
@JessicaJHee
Copy link
Contributor Author

For records: Locally tested as well with the options useRedisSets=true and useRedisSets=false and observed the expected change in cache key names

WithuseRedisSets=false :
image
With useRedisSets=true :
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants