Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.3] fix gitlab-org wrapper #2116

Conversation

kadel
Copy link
Member

@kadel kadel commented Dec 17, 2024

Description

fixes missing embedded dependency in gitlab-org plugin

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Copy link

openshift-ci bot commented Dec 17, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kadel kadel force-pushed the release-1.3-fix-gitlab-org branch from 1de535b to cb137e3 Compare December 18, 2024 09:23
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-2116!

@kadel kadel marked this pull request as ready for review December 18, 2024 11:16
@kadel kadel requested a review from a team as a code owner December 18, 2024 11:16
@openshift-ci openshift-ci bot requested review from 04kash and dzemanov December 18, 2024 11:17
Copy link
Member

@gashcrumb gashcrumb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

openshift-ci bot commented Dec 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gashcrumb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gashcrumb
Copy link
Member

/retest

@kadel
Copy link
Member Author

kadel commented Dec 18, 2024

not sure what is going on with tests

/bin/bash: line 2: /tmp/droute-linux-amd64: Text file busy
command terminated with exit code 126

/retest

@kadel
Copy link
Member Author

kadel commented Dec 19, 2024

#2125 should resolve droute issue

@subhashkhileri
Copy link
Contributor

/test e2e-tests

@openshift-ci openshift-ci bot removed the lgtm label Dec 19, 2024
Copy link

openshift-ci bot commented Dec 19, 2024

New changes are detected. LGTM label has been removed.

@kadel kadel added the lgtm label Dec 19, 2024
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-2116!

@openshift-merge-bot openshift-merge-bot bot merged commit 4d2e23d into redhat-developer:release-1.3 Dec 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants