chore(wrapper): add wrapper for marketplace frontend, backend and catalog-backend-module plugins #2156
Conversation
karthikjeeyar
force-pushed
the
add-marketplace-wrapper
branch
7 times, most recently
from
62d25cc to
0c4d778
Compare
|
/test e2e-tests |
|
The image is available at: |
karthikjeeyar
force-pushed
the
add-marketplace-wrapper
branch
from
d1f2829 to
4235077
Compare
|
The image is available at: |
| @@ -1010,3 +1010,26 @@ plugins: | |||
| catalog: | |||
| providers: | |||
| pingIdentityOrg: {} | |||
| # Group: Marketplace | |||
| - package: ./dynamic-plugins/dist/red-hat-developer-hub-backstage-plugin-catalog-backend-module-marketplace-dynamic | |||
| disabled: true | |||
...d-hat-developer-hub-backstage-plugin-catalog-backend-module-marketplace-dynamic/package.json
Outdated
Show resolved
Hide resolved
...ins/wrappers/red-hat-developer-hub-backstage-plugin-marketplace-backend-dynamic/package.json
Outdated
Show resolved
Hide resolved
...ugins/wrappers/red-hat-developer-hub-backstage-plugin-marketplace-backend-dynamic/turbo.json
Outdated
Show resolved
Hide resolved
dynamic-plugins/wrappers/red-hat-developer-hub-backstage-plugin-marketplace/package.json
Outdated
Show resolved
Hide resolved
dynamic-plugins/wrappers/red-hat-developer-hub-backstage-plugin-marketplace/turbo.json
Outdated
Show resolved
Hide resolved
|
The image is available at: |
| }, | ||
| "repository": { | ||
| "type": "git", | ||
| "url": "https://github.com/janus-idp/backstage-showcase", |
There was a problem hiding this comment.
Reminder for myself: we need to update this
| "directory": "dynamic-plugins/wrappers/red-hat-developer-hub-backstage-plugin-marketplace" | ||
| }, | ||
| "maintainers": [ | ||
| "@janus-idp/maintainers-showcase" |
There was a problem hiding this comment.
Reminder for myself: we need to update this
|
/retest |
2 similar comments
|
/retest |
|
/retest |
plugins/dynamic-plugins-info/src/components/InternalPluginsMap.ts
Outdated
Show resolved
Hide resolved
karthikjeeyar
force-pushed
the
add-marketplace-wrapper
branch
from
d43de66 to
69e1b75
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
The image is available at: |
|
This lgtm, just waiting for for e2e tests after we migrated this git repo. Will add lgtm label then. |
|
/retest |
|
/retest |
Description
Add dynamic plugin wrappers for marketplace, marketplace-backend and catalog-backend-module-marketplace plugins.
Which issue(s) does this PR fix
https://issues.redhat.com/browse/RHIDP-5322
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer