-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): refactor hardcoded backstage-showcase in e2e tests #2172
chore(ci): refactor hardcoded backstage-showcase in e2e tests #2172
Conversation
Skipping CI for Draft Pull Request. |
/test all |
The image is available at: |
/test e2e-tests |
/test e2e-tests |
The image is available at: |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: josephca The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
73d8bff
into
redhat-developer:main
/cherry-pick release-1.4 |
@zdrapela: only redhat-developer org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cherry-pick release-1.4 |
/cherry-pick release-1.3 |
@zdrapela: #2172 failed to apply on top of branch "release-1.4":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@zdrapela: #2172 failed to apply on top of branch "release-1.3":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@zdrapela please refer to the comment: #2174 (comment) Latest images are at https://quay.io/repository/rhdh-community/rhdh?tab=tags&tag=latest instead of in the janus-idp/backstage-showcase quay location. Please update accordingly. Please open a new PR if required. Thanks! |
…-developer#2172) * chore(ci): refactor hardcoded backstage-showcase in e2e tests * Fix declaration * Fix cp *
Description
Refactor e2e tests that use hardcoded
janus-idp/backstage-showcase
=>redhat-developer/rhdh
(folders, yaml references etc.)I kept the references to
quay.io/janus-idp/backstage-showcase
.This fixes this error caused by having hardcoded variables and the repo migration:
Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer