Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(dynamic-plugins): update todo plugin instructions and add TypeScript compilation step #2182

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

durandom
Copy link
Member

@durandom durandom commented Jan 14, 2025

  • add missing typescript compile step
  • made dynamic plugins config copy-paste proof

Signed-off-by: Marcel Hild hild@b4mad.net

…ript compilation step

Signed-off-by: Marcel Hild <hild@b4mad.net>
@durandom durandom force-pushed the fix_dynamic_plugins_docs branch from 97e6fe3 to ad6cc50 Compare January 14, 2025 15:31
@kadel
Copy link
Member

kadel commented Jan 14, 2025

markdown check fails due to broken links unrelated to this:

I'll open PR to fix this tomorrow.


FILE: docs/e2e-tests/CI.md
[✓] https://github.com/janus-idp/backstage-showcase
[✓] https://github.com/janus-idp
[✓] https://github.com/kubernetes/community/blob/master/contributors/guide/pull-requests.md#more-about-ok-to-test
[✓] #high-level-overview-of-openshift-ci-testssh
[✓] https://prow.ci.openshift.org/
[✓] ../images/github_diagram.svg
[✓] ../images/nightly_diagram.svg
[✓] ../../.ibm/pipelines/openshift-ci-tests.sh
[✓] https://github.com/janus-idp/backstage-showcase/blob/main/.ibm/images/Dockerfile
[✖] https://github.com/openshift/release/tree/master/ci-operator/jobs/janus-idp/backstage-showcase
[✖] https://github.com/openshift/release/tree/master/ci-operator/config/janus-idp/backstage-showcase
[✖] https://github.com/openshift/release/tree/master/ci-operator/step-registry/janus-idp/backstage-showcase

12 links checked.

ERROR: 3 dead links found!
[✖] https://github.com/openshift/release/tree/master/ci-operator/jobs/janus-idp/backstage-showcase → Status: 404
[✖] https://github.com/openshift/release/tree/master/ci-operator/config/janus-idp/backstage-showcase → Status: 404
[✖] https://github.com/openshift/release/tree/master/ci-operator/step-registry/janus-idp/backstage-showcase → Status: 404
(node:261) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)

@kadel
Copy link
Member

kadel commented Jan 15, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 15, 2025
Copy link

openshift-ci bot commented Jan 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants