Skip to content

Conversation

dantovska
Copy link
Collaborator

@dantovska dantovska commented Aug 13, 2025

Renaming telemetry events and providers, to match the new names for Redis Cloud and Redis Cluster.

  • rename telemetry events
  • rename providers
  • create migration script to update the provider property for already existing instances

Telemetry events:

RE_CLUSTER -> REDIS_SOFTWARE applied to:

  • CONFIG_DATABASES_RE_CLUSTER_AUTODISCOVERY_SUBMITTED
  • CONFIG_DATABASES_RE_CLUSTER_AUTODISCOVERY_SUCCEEDED
  • CONFIG_DATABASES_RE_CLUSTER_AUTODISCOVERY_FAILED
  • CONFIG_DATABASES_RE_CLUSTER_AUTODISCOVERY_CANCELLED

RE_CLOUD -> REDIS_CLOUD applied to:

  • CONFIG_DATABASES_RE_CLOUD_AUTODISCOVERY_SUBMITTED
  • CONFIG_DATABASES_RE_CLOUD_AUTODISCOVERY_SUBSCRIPTIONS_SUCCEEDED
  • CONFIG_DATABASES_RE_CLOUD_AUTODISCOVERY_SUBSCRIPTIONS_FAILED
  • CONFIG_DATABASES_RE_CLOUD_AUTODISCOVERY_DATABASES_SUCCEEDED
  • CONFIG_DATABASES_RE_CLOUD_AUTODISCOVERY_DATABASES_FAILED
  • CONFIG_DATABASES_RE_CLOUD_AUTODISCOVERY_CANCELLED

Providers:

  • RE_CLOUD -> REDIS_CLOUD
  • RE_CLUSTER -> REDIS_SOFTWARE
  • REDIS_ENTEPRISE -> OTHER_REDIS_MANAGED

Refactoring other methods/variables/constants for concistency:

  • RE_CLOUD to REDIS_CLOUD
  • RE_CLUSTER to REDIS_SOFTWARE
  • ignored the REDIS_ENTEPRISE to OTHER_REDIS_MANAGED - did not make sense as a name. For Example RedisEnterpriseDto -> OtherRedisManagedDto doesn't make sense to me.

@dantovska dantovska self-assigned this Aug 13, 2025
Copy link
Contributor

github-actions bot commented Aug 13, 2025

Code Coverage - Integration Tests

Status Category Percentage Covered / Total
🟢 Statements 81.54% 16223/19895
🟡 Branches 64.41% 7308/11345
🟡 Functions 70.32% 2270/3228
🟢 Lines 81.17% 15261/18800

Copy link
Contributor

github-actions bot commented Aug 13, 2025

Code Coverage - Backend unit tests

St.
Category Percentage Covered / Total
🟢 Statements 92.34% 13840/14988
🟡 Branches 74.04% 4176/5640
🟢 Functions 85.85% 2129/2480
🟢 Lines 92.14% 13229/14358

Test suite run success

2950 tests passing in 286 suites.

Report generated by 🧪jest coverage report action from 841d3c1

Copy link
Contributor

github-actions bot commented Aug 13, 2025

Code Coverage - Frontend unit tests

St.
Category Percentage Covered / Total
🟢 Statements 81.93% 19751/24106
🟡 Branches 67.29% 8569/12734
🟡 Functions 76.01% 5243/6898
🟢 Lines 82.36% 19332/23473

Test suite run success

5079 tests passing in 669 suites.

Report generated by 🧪jest coverage report action from 841d3c1

valkirilov
valkirilov previously approved these changes Aug 18, 2025
RECloudSubscriptionsDiscoveryFailed = 'CONFIG_DATABASES_RE_CLOUD_AUTODISCOVERY_SUBSCRIPTIONS_FAILED',
RECloudDatabasesDiscoverySucceed = 'CONFIG_DATABASES_RE_CLOUD_AUTODISCOVERY_DATABASES_SUCCEEDED',
RECloudDatabasesDiscoveryFailed = 'CONFIG_DATABASES_RE_CLOUD_AUTODISCOVERY_DATABASES_FAILED',
RedisSoftwareDiscoverySucceed = 'CONFIG_DATABASES_REDIS_SOFTWARE_AUTODISCOVERY_SUCCEEDED',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: I might be missing something here, but why change both the constant names and their values? Usually, we use constants to hide the magic strings so we don’t need to update the whole codebase later. Or in this case, were the names actually wrong/misleading and needed to be updated too?

PS: Since you already made the effort to migrate everything, don't make any further changes, I'm just curious 🙂

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get your point and it makes sense for constants name to stay in general, but maybe if the constant name was descriptive and general enough, but this "RECloud" part I think it is both not descriptive and will look like a leftover we wouldn't have cleaned, at least to me ...

Copy link
Collaborator

@ArtemHoruzhenko ArtemHoruzhenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not completely agree with renaming function names because of possible regression but in genreal it is better when names aligned with each other
Looks good but can't approve before migration checks

@dantovska dantovska force-pushed the feature/RI-6927-rename-providers-events branch from 77a1114 to 841d3c1 Compare August 25, 2025 11:59
@dantovska dantovska merged commit 380fd85 into main Aug 26, 2025
34 checks passed
@dantovska dantovska deleted the feature/RI-6927-rename-providers-events branch August 26, 2025 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants