-
Notifications
You must be signed in to change notification settings - Fork 396
RI-6927: Rename some provider and telemetry event names #4855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Code Coverage - Integration Tests
|
Code Coverage - Backend unit tests
Test suite run success2950 tests passing in 286 suites. Report generated by 🧪jest coverage report action from 841d3c1 |
Code Coverage - Frontend unit tests
Test suite run success5079 tests passing in 669 suites. Report generated by 🧪jest coverage report action from 841d3c1 |
RECloudSubscriptionsDiscoveryFailed = 'CONFIG_DATABASES_RE_CLOUD_AUTODISCOVERY_SUBSCRIPTIONS_FAILED', | ||
RECloudDatabasesDiscoverySucceed = 'CONFIG_DATABASES_RE_CLOUD_AUTODISCOVERY_DATABASES_SUCCEEDED', | ||
RECloudDatabasesDiscoveryFailed = 'CONFIG_DATABASES_RE_CLOUD_AUTODISCOVERY_DATABASES_FAILED', | ||
RedisSoftwareDiscoverySucceed = 'CONFIG_DATABASES_REDIS_SOFTWARE_AUTODISCOVERY_SUCCEEDED', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: I might be missing something here, but why change both the constant names and their values? Usually, we use constants to hide the magic strings so we don’t need to update the whole codebase later. Or in this case, were the names actually wrong/misleading and needed to be updated too?
PS: Since you already made the effort to migrate everything, don't make any further changes, I'm just curious 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get your point and it makes sense for constants name to stay in general, but maybe if the constant name was descriptive and general enough, but this "RECloud" part I think it is both not descriptive and will look like a leftover we wouldn't have cleaned, at least to me ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not completely agree with renaming function names because of possible regression but in genreal it is better when names aligned with each other
Looks good but can't approve before migration checks
redisinsight/api/migration/1755086732238-update-provider-names.ts
Outdated
Show resolved
Hide resolved
redisinsight/api/migration/1755086732238-update-provider-names.ts
Outdated
Show resolved
Hide resolved
…ER to REDIS_SOFTWARE
…her redis managed as it didn't make sense...
…e migration script
77a1114
to
841d3c1
Compare
Renaming telemetry events and providers, to match the new names for Redis Cloud and Redis Cluster.
Telemetry events:
RE_CLUSTER -> REDIS_SOFTWARE applied to:
RE_CLOUD -> REDIS_CLOUD applied to:
Providers:
Refactoring other methods/variables/constants for concistency: