Skip to content

Conversation

dantovska
Copy link
Collaborator

@dantovska dantovska commented Aug 19, 2025

Before After
image image
image image
image image
image image

How to test:

  1. Open an instance (go to Browser Page).
  2. Click on the Redis Insights bulb icon to view Tutorials and Tips.
image
  1. Click on the Tips.
  2. Open one of them. If none exist, click on the Run Database Analysis below.
image
  1. Expand one of the accordions.

Copy link
Contributor

github-actions bot commented Aug 19, 2025

Code Coverage - Frontend unit tests

St.
Category Percentage Covered / Total
🟢 Statements 81.94% 19761/24116
🟡 Branches 67.34% 8576/12736
🟡 Functions 76.03% 5247/6901
🟢 Lines 82.37% 19344/23484

Test suite run success

5078 tests passing in 669 suites.

Report generated by 🧪jest coverage report action from cf4fd3a

KrumTy
KrumTy previously approved these changes Aug 19, 2025
@pd-redis
Copy link
Collaborator

Are these changes - colors, fonts - because the design requires them?
Also, we are trying to move away from scss and custom colors. I would look for matching or similar color in the theme and use it.

@dantovska
Copy link
Collaborator Author

dantovska commented Aug 20, 2025

Are these changes - colors, fonts - because the design requires them? Also, we are trying to move away from scss and custom colors. I would look for matching or similar color in the theme and use it.

@pd-redis
If you referring to the recommendationsBgColor, I'm changing it in one place as where it's used I want to set the same color - greyish and not entirely white. This color is actually fixing the background for "Is this useful?" wrapper. I think this is the best best solution for this problem.
I'm not sure if we have discussed how to handle background styles for components though... maybe you are thinking of creating a styled wrapper component where we can just set a theme color instead of experimenting with the palette?

valkirilov
valkirilov previously approved these changes Aug 20, 2025
@pd-redis
Copy link
Collaborator

Are these changes - colors, fonts - because the design requires them? Also, we are trying to move away from scss and custom colors. I would look for matching or similar color in the theme and use it.

@pd-redis If you referring to the recommendationsBgColor, I'm changing it in one place as where it's used I want to set the same color - greyish and not entirely white. This color is actually fixing the background for "Is this useful?" wrapper. I think this is the best best solution for this problem. I'm not sure if we have discussed how to handle background styles for components though... maybe you are thinking of creating a styled wrapper component where we can just set a theme color instead of experimenting with the palette?

We Should use styled wrapper and not scss for sure.
And use a theme color which is alredy in the theme and is relatively close to the one currently used

@dantovska dantovska dismissed stale reviews from valkirilov and KrumTy via 2098038 August 25, 2025 06:00
@dantovska dantovska force-pushed the fe/feature/RI-7347-links-highlights-broken branch from 655a338 to 2098038 Compare August 25, 2025 06:00
valkirilov
valkirilov previously approved these changes Aug 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants