DOC 2644 - adds Stream examples in Node.js #2654
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjpotter
reviewed
Jun 13, 2024
| 'location_id': '1' | ||
| } | ||
| ); | ||
| console.log(res1); // >>> 1700073067968-0 |
There was a problem hiding this comment.
without context of how comments here were done before, what is this implying, that it should be greater than that value?
sjpotter
reviewed
Jun 13, 2024
| count: 100, | ||
| block: 300 | ||
| }); | ||
| console.log(res5); // >>> [['race:france', [('1692629576966-0', {'rider': 'Castilla', 'speed': '30.2', 'position': '1', 'location_id': '1'}), ('1692629594113-0', {'rider': 'Norem', 'speed': '28.8', 'position': '3', 'location_id': '1'}), ('1692629613374-0', {'rider': 'Prickett', 'speed': '29.7', 'position': '2', 'location_id': '1'})]]] |
There was a problem hiding this comment.
note that these id values dont correspond to the comments above, perhaps there should be more consistency in how we refer to variable" settings (ala IDs)
sjpotter
reviewed
Jun 13, 2024
| // STEP_END | ||
|
|
||
| // STEP_START xRange_time | ||
| const res12 = await client.xRange('race:france', '1692629576965', '1692629576967'); |
There was a problem hiding this comment.
because of the above mentioned id issue, this now can fail,
sjpotter
reviewed
Jun 13, 2024
| const res16 = await client.xRevRange('race:france', '+', '-', 1); | ||
| console.log( | ||
| res16 | ||
| ); // >>> [('1692629676124-0', {'rider': 'Castilla', 'speed': '29.9', 'position': '1', 'location_id': '2'})] |
There was a problem hiding this comment.
I'm getting all 4 results here, doesn't seem ID based?
|
my primary comment here (which makes it harder to test) is that the IDs generated dont correspond to what a user would see if running it themselves, which then breaks the rest of the example code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DOC-2644
Checklist
npm testpass with this change (including linting)?