Skip to content

Commit

Permalink
aws/sqs: downgrade reset failures to info logs
Browse files Browse the repository at this point in the history
  • Loading branch information
rockwotj committed Jan 6, 2025
1 parent 6780bb4 commit 62fdee3
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion internal/impl/aws/input_sqs.go
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,12 @@ func (a *awsSQSReader) ackLoop(wg *sync.WaitGroup, inFlightTracker *sqsInFlightT
}
} else {
if err := a.resetMessages(closeNowCtx, handles...); err != nil {
a.log.Errorf("Failed to reset the visibility timeout of messages: %v", err)
// Downgrade this to Info level - it's not really an error, it's just going to take longer
// to reset the visibility so the messages might be delayed is all. It's possible for delays
// if this succeeds anyways as it might be racing with the refresh loop. Fixing that
// would mean moving nacks to the refresh loop, but I don't think this will be a big deal in
// practice.
a.log.Infof("Failed to reset the visibility timeout of messages: %v", err)
}
}
}
Expand Down

0 comments on commit 62fdee3

Please sign in to comment.