Skip to content

Commit

Permalink
Remove cgo builds (#3030)
Browse files Browse the repository at this point in the history
* Remove cgo builds

* Add command to CL entry
  • Loading branch information
Jeffail authored Nov 22, 2024
1 parent 0308fa8 commit b7cc2bc
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 71 deletions.
7 changes: 0 additions & 7 deletions .github/workflows/docker_edge.yml
Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,3 @@ jobs:
push: true
tags: redpandadata/connect:edge-cloud

- name: Build and push CGO
uses: docker/build-push-action@v6
with:
context: ./
file: ./resources/docker/Dockerfile.cgo
push: true
tags: redpandadata/connect:edge-cgo
7 changes: 1 addition & 6 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -80,11 +80,6 @@ jobs:
suffix: ""
platform: linux/amd64,linux/arm64
file: ./resources/docker/Dockerfile
- flavor: cgo
latest: false
suffix: -cgo
platform: linux/amd64
file: ./resources/docker/Dockerfile.cgo
- flavor: cloud
latest: false
suffix: -cloud
Expand Down Expand Up @@ -138,7 +133,7 @@ jobs:
uses: docker/setup-buildx-action@v3

- name: Write telemetry private key
if: ${{ matrix.suffix == '' || matrix.suffix == '-cgo' }}
if: ${{ matrix.suffix == '' }}
env:
CONNECT_TELEMETRY_PRIV_KEY: ${{ secrets.TELEMETRY_PRIVATE_KEY }}
run: |
Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ All notable changes to this project will be documented in this file.

- Field `max_records_per_request` added to the `aws_sqs` output. (@Jeffail)

### Changed

- The `-cgo` suffixed docker images are no longer built and pushed along with the regular images. This decision was made due to low demand, and the unacceptable cadence with which the image base (Debian) receives security updates. It is still possible to create your own CGO builds with the command `CGO_ENABLED=1 make TAGS=x_benthos_extra redpanda-connect`.

## 4.40.0 - 2024-11-21

### Added
Expand Down
9 changes: 1 addition & 8 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
.PHONY: all deps docker docker-cgo clean test test-race test-integration fmt lint install
.PHONY: all deps docker clean test test-race test-integration fmt lint install

TAGS ?=

Expand Down Expand Up @@ -48,9 +48,6 @@ docker-tags:
docker-rc-tags:
@echo "latest,$(VER_CUT),$(VER_MAJOR)-$(VER_RC)" > .tags

docker-cgo-tags:
@echo "latest-cgo,$(VER_CUT)-cgo,$(VER_MAJOR).$(VER_MINOR)-cgo,$(VER_MAJOR)-cgo" > .tags

docker:
@docker build -f ./resources/docker/Dockerfile . -t $(DOCKER_IMAGE):$(VER_CUT)
@docker tag $(DOCKER_IMAGE):$(VER_CUT) $(DOCKER_IMAGE):latest
Expand All @@ -63,10 +60,6 @@ docker-ai:
@docker build -f ./resources/docker/Dockerfile.ai . -t $(DOCKER_IMAGE):$(VER_CUT)-ai
@docker tag $(DOCKER_IMAGE):$(VER_CUT)-ai $(DOCKER_IMAGE):latest-ai

docker-cgo:
@docker build -f ./resources/docker/Dockerfile.cgo . -t $(DOCKER_IMAGE):$(VER_CUT)-cgo
@docker tag $(DOCKER_IMAGE):$(VER_CUT)-cgo $(DOCKER_IMAGE):latest-cgo

fmt:
@go list -f {{.Dir}} ./... | xargs -I{} gofmt -w -s {}
@go list -f {{.Dir}} ./... | xargs -I{} goimports -w -local github.com/redpanda-data/connect/v4 {}
Expand Down
50 changes: 0 additions & 50 deletions resources/docker/Dockerfile.cgo

This file was deleted.

0 comments on commit b7cc2bc

Please sign in to comment.