-
Notifications
You must be signed in to change notification settings - Fork 847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support NAK delay on nats_jetstream
input
#2556
Open
mfamador
wants to merge
5
commits into
redpanda-data:main
Choose a base branch
from
anovateam:nats-jetstream-nak-delay
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+161
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfamador
changed the title
Support a nak_delay on NATS Jetstream input
Support a general nak_delay for all msgs and a header to set the nak_delay individually for each msg on NATS Jetstream input
Apr 30, 2024
mfamador
force-pushed
the
nats-jetstream-nak-delay
branch
2 times, most recently
from
April 30, 2024 15:31
c648244
to
10320aa
Compare
mfamador
force-pushed
the
nats-jetstream-nak-delay
branch
from
May 23, 2024 18:34
4c91ff2
to
ee570c0
Compare
mfamador
changed the title
Support a general nak_delay for all msgs and a header to set the nak_delay individually for each msg on NATS Jetstream input
Support a NAK delay
May 23, 2024
mfamador
force-pushed
the
nats-jetstream-nak-delay
branch
2 times, most recently
from
May 23, 2024 20:15
d9c4ee7
to
3678abe
Compare
mfamador
changed the title
Support a NAK delay
Support a NAK delay to May 23, 2024
nats_jetstream
input
mfamador
changed the title
Support a NAK delay to
Support NAK delay on May 23, 2024
nats_jetstream
inputnats_jetstream
input
mfamador
force-pushed
the
nats-jetstream-nak-delay
branch
2 times, most recently
from
May 29, 2024 11:11
955071f
to
f6875ac
Compare
mfamador
force-pushed
the
nats-jetstream-nak-delay
branch
4 times, most recently
from
June 4, 2024 12:20
033c28c
to
acf260b
Compare
mfamador
force-pushed
the
nats-jetstream-nak-delay
branch
from
October 4, 2024 14:18
acf260b
to
2d4241d
Compare
Signed-off-by: Marco Amador <amador.marco@gmail.com>
…hen in clustered mode Signed-off-by: Marco Amador <amador.marco@gmail.com>
mfamador
force-pushed
the
nats-jetstream-nak-delay
branch
from
January 10, 2025 21:43
195c6aa
to
723a423
Compare
Removed the part where we try to update the stream if we change the subject. This way it has the same behaviour as without the create_if_not_exists flag on which it fails if we don't change the durable/consumer as well. To be able to read to all subjects the stream is created with subjects "*" |
…out create_if_not_exists flag.
mfamador
force-pushed
the
nats-jetstream-nak-delay
branch
from
January 11, 2025 14:22
cdec89a
to
d947241
Compare
…out create_if_not_exists flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an optional parameter to make NATS Jetstream to delay the redelivery of all msgs when negatively acknowledged. It can be used as a retry mechanism when a transient error occurs.
Additionally, we can use a header on each msg to define the unix epoch timestamp until when we want to delay the msg processing. By default is
nak_delay_until
but we can set it with another name using the parameternak_delay_until_header
It was also added an opt-in parameter to create the stream and subject if they not exist and another to specify the number of stream replicas when in clustered mode.