Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update common-go with updates to reading secrets from Azure key vault and configuring secret trim prefix #3018

Merged
merged 4 commits into from
Nov 21, 2024
Merged

Update common-go with updates to reading secrets from Azure key vault and configuring secret trim prefix #3018

merged 4 commits into from
Nov 21, 2024

Conversation

tomasz-sadura
Copy link
Contributor

@tomasz-sadura tomasz-sadura commented Nov 19, 2024 •
edited
Loading

@tomasz-sadura tomasz-sadura changed the title Update common-go with updates to reading secrets from Azure key vault Update common-go with updates to reading secrets from Azure key vault and configuring secret trim prefix Nov 20, 2024
nicolaferraro
nicolaferraro approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@nicolaferraro nicolaferraro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pls make sure this is documented.

@Jeffail Jeffail merged commit ec0bc31 into main Nov 21, 2024
2 of 3 checks passed
@Jeffail Jeffail deleted the update-common-with-secrets-update branch November 21, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolaferraro nicolaferraro nicolaferraro approved these changes

@Jeffail Jeffail Awaiting requested review from Jeffail

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomasz-sadura @nicolaferraro @Jeffail