chore(mongodb): upgrade driver to version 2.0.0 #3108
Conversation
ooesili
added
dependencies
| @@ -188,10 +188,13 @@ func (m *Processor) ProcessBatch(ctx context.Context, batch service.MessageBatch | |||
| Hint: hintJSON, | |||
| } | |||
| case OperationFindOne: | |||
| collection := m.database.Collection(collectionStr, m.writeConcernCollectionOption) | |||
| ctx, cancel := context.WithTimeout(context.Background(), m.writeConcernSpec.wTimeout) | |||
There was a problem hiding this comment.
Read timeout? Seems wrong to use a write timeout here...
There was a problem hiding this comment.
Or maybe we should deprecate writeConcernSpec.wTimeout the and just use the ProcessBatch ctx instead. Not sure why it wasn't used before...
Same for the output since https://github.com/mongodb/mongo-go-driver/blob/v2.0.0/docs/migration-2.0.md#wtimeout
The
WTimeoutfield has been removed from theWriteConcernstruct. Instead, users should define a timeout at the operation-level using a context object.
To deprecate a field, we typically remove it from everywhere except the docs (see example here and here) and mention it in the Changelog.
|
Looks good thanks! Looks like the linter is :blobmad: |
There was a problem hiding this comment.
Nice job @ooesili! I just left one small comment, but feel free to ignore it if it would cause trouble for users. Otherwise feel free to 
| @@ -188,10 +188,13 @@ func (m *Processor) ProcessBatch(ctx context.Context, batch service.MessageBatch | |||
| Hint: hintJSON, | |||
| } | |||
| case OperationFindOne: | |||
| collection := m.database.Collection(collectionStr, m.writeConcernCollectionOption) | |||
| ctx, cancel := context.WithTimeout(context.Background(), m.writeConcernSpec.wTimeout) | |||
There was a problem hiding this comment.
Or maybe we should deprecate writeConcernSpec.wTimeout the and just use the ProcessBatch ctx instead. Not sure why it wasn't used before...
Same for the output since https://github.com/mongodb/mongo-go-driver/blob/v2.0.0/docs/migration-2.0.md#wtimeout
The
WTimeoutfield has been removed from theWriteConcernstruct. Instead, users should define a timeout at the operation-level using a context object.
To deprecate a field, we typically remove it from everywhere except the docs (see example here and here) and mention it in the Changelog.
SetSocketTimeoutwas removed, and its usage has been replaced withSetTimeoutWriteConcernstruct no longer contains a timeout field, context is used instead, so I added a wrapper struct with this field to minimize code changesoptionspackages has been overhauled so there are a bunch of code changes around setting optionsFor more information, see this doc https://github.com/mongodb/mongo-go-driver/blob/v2.0.0/docs/migration-2.0.md