Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ollama: support tool calling #3110

Merged
merged 6 commits into from
Jan 10, 2025
Merged

ollama: support tool calling #3110

merged 6 commits into from
Jan 10, 2025

Conversation

rockwotj
Copy link
Collaborator

  • ollama: support tool calls
  • ollama: bump version
  • ollama: upgrade to latest version
  • ollama: append the model response when calling tools

@rockwotj rockwotj requested a review from mihaitodor January 10, 2025 20:47
mihaitodor
mihaitodor approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@mihaitodor mihaitodor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks Tyler! I just left a few small nits. Feel free to :shipit:

internal/impl/ollama/chat_processor.go Outdated Show resolved Hide resolved
internal/impl/ollama/chat_processor.go Show resolved Hide resolved
@rockwotj rockwotj merged commit e3f9827 into main Jan 10, 2025
4 checks passed
@rockwotj rockwotj deleted the ollama-tools branch January 10, 2025 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaitodor mihaitodor mihaitodor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rockwotj @mihaitodor