Show default config for topic configurations #1580
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jvorcak
commented
Jan 8, 2025
jvorcak
commented
- We needed to remove altering data structures in the backendAPI (moved to ConfigList where it was needed)
- We added an information about default value to the topic config form
weeco
reviewed
Jan 9, 2025
| @@ -127,6 +127,8 @@ const ConfigEditorForm: FC<{ | |||
|
|
|||
| const valueType = watch('valueType'); | |||
|
|
|||
| const defaultConfigSynonym = editedEntry.synonyms?.find((x) => x.source === 'DEFAULT_CONFIG'); | |||
There was a problem hiding this comment.
That's not always correct. A topic config may be inherited from:
- Default Config (defined in Redpanda / Apache Kafka if nothing is set)
- A default for all topics is set at the broker/cluster level (STATIC_BROKER_CONFIG / DYNAMIC_DEFAULT_BROKER_CONFIG / DYNAMIC_BROKER_CONFIG), basically to override the default config
or it is set at the Topic level (DYNAMIC_TOPIC_CONFIG) which is the custom/override case.
There was a problem hiding this comment.
@weeco in that case FE doesn't have this information. On this place we show this information only for default tab, so we don't care about a topic level intentionaly. However, if not set at a topic level, it can be set at multiple levels above, is there a hierarchy for this so that I can determine the default from synonyms array?
There was a problem hiding this comment.
Yes there's a hierarchy, it should be this order (top to bottom):
- DYNAMIC_TOPIC_CONFIG
- DYNAMIC_BROKER_CONFIG
- DYNAMIC_DEFAULT_BROKER_CONFIG
- STATIC_BROKER_CONFIG
- DEFAULT_CONFIG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.