Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC-31 add rpk tutorial #935

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

DOC-31 add rpk tutorial #935

wants to merge 8 commits into from

Conversation

Deflaimun
Copy link
Contributor

@Deflaimun Deflaimun commented Dec 19, 2024

Description

Resolves https://github.com/redpanda-data/documentation-private/issues/1373
Resolves https://redpandadata.atlassian.net/browse/DOC-31
Review deadline: Jan 7th

Page previews

https://deploy-preview-935--redpanda-docs-preview.netlify.app/current/get-started/rpk-first-steps/

Checks

  • New feature
  • Content gap
  • Support Follow-up
  • Small fix (typos, links, copyedits, etc)

@Deflaimun Deflaimun requested a review from a team as a code owner December 19, 2024 20:51
Copy link

netlify bot commented Dec 19, 2024

Deploy Preview for redpanda-docs-preview ready!

Name Link
🔨 Latest commit 413e13a
🔍 Latest deploy log https://app.netlify.com/sites/redpanda-docs-preview/deploys/6765801e25090900089d2365
😎 Deploy Preview https://deploy-preview-935--redpanda-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Deflaimun Deflaimun requested a review from r-vasquez December 19, 2024 20:54
@Deflaimun Deflaimun changed the title add rpk tutorial DOC-31 add rpk tutorial Dec 19, 2024
// Do not put page aliases in the single-sourced content
// tag::single-source[]

This guide shows you how to use `rpk` to perform fundamental Redpanda tasks, including creating, producing to, describing, and deleting topics, as well as consuming records and managing consumer groups. Following these examples will help you quickly become more familiar with `rpk` commands and integrate them into your workflow.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks great, the only thing I'll add is creating a profile as a first step, so they don't have to wonder how to run the command against a cluster.

Alternatively, we could say that you can try this tutorial using rpk container start which creates a profile automatically and links to the profile docs as additional documentation.

Back when we created the issue we didn't have profiles

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I was thinking about that. We have the create profile page before this one. But I think we could combine those into a single page. Specially for cloud


See xref:reference:rpk/rpk-topic/rpk-topic-delete.adoc[].

== Next steps
Copy link
Contributor

@micheleRP micheleRP Dec 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you don't merge this with the rpk Profile page, then add a link to it here.
Also, you should add a link to this page in the Intro to rpk page!

@@ -0,0 +1,240 @@
= Quickstart with rpk
Copy link
Contributor

@micheleRP micheleRP Dec 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could consider moving it this page into the Quickstart section in the left nav, and just have links to it in the pages in the Redpanda CLI section.

Copy link
Contributor

@micheleRP micheleRP Dec 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you do move it there, I'd probably rename the title to something like Redpanda CLI Quickstart and page to rpk-quickstart.adoc.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or Redpanda rpk Quickstart?

@@ -0,0 +1,240 @@
= Quickstart with rpk
:page-categories: rpk
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a :description:, so the description appears in the index page.

Produced to partition 0 at offset 0 with timestamp 1734640650348.
Produced to partition 0 at offset 1 with timestamp 1734640653558.
----

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should you say you need to Ctrl-C?

Co-authored-by: Michele Cyran <michele@redpanda.com>

== Next steps

For the complete list of `rpk` commands and their syntax, see the xref:reference:rpk/index.adoc[rpk reference].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears in the navtree as Reference > rpk Commands
The heading on the page also reads rpk Commands
So shouldn't this be see the rpk Command Reference?

@Feediver1
Copy link
Contributor

Thanks for this one--long needed!

Copy link
Contributor

@r-vasquez r-vasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one small comment.

rpk topic consume tutorial --group tutorial-group
----

NOTE: The consumer group is created when you consume from the topic.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
NOTE: The consumer group is created when you consume from the topic.
NOTE: The consumer group is created when you start consuming from the topic.

Probably better, wdyt? as when you consume may imply that only is created when you consume records, but the consumer might be idle waiting for new messages and the consumer group still will be created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants