Add 'ready' entrypoint for exec-based readiness checks #380
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently stacked on the PR wiring up the ready probe for the sidecar, but it introduces an entrypoint for also issuing a single exec-based readiness check using the same underlying prober (but with the more relaxed
IsClusterBrokerReady
rather than executingIsClusterBrokerHealthy
). Adding this as after talking with @birdayz we discussed that for the current v1-based nodes in cloud the constrained resources would likely not work well with provisioning an additional sidecar that would sap resources from the main container.Instead they can exec the probe directly in the main container and we move ever so closer to having more shared components between the v1/v2 implementation.
Once #379 lands I can adjust the base branches here.