Remove unused configurator Operator chart values #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisseto
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
I don't think it matters for this specific change as there should only be internal users of these flags but this is a backwards incompatible change that would silently begin to fail in existing installations.
For anyone using these values, the next update would see the operator suddenly drop their configurator override without any warning. A deprecation is generally backwards compatible or fails loudly.
.changes/unreleased/chart-operator-Removed-20250110-143018.yaml
Outdated
Show resolved
Hide resolved
| For any user that is mirroring configurator image (air-gapped environment) and changes entrypoint | ||
| or wraps configurator with additional script the following constraint need to be meet: | ||
| * set the following flags | ||
| * to change the container repository set `--configurator-base-image=my.repo.com/configurator` flag |
There was a problem hiding this comment.
I don't think this needs to be specified as this behavior did not change? Or is this meant to call out that the default repository/image has changed?
RafalKorepta
force-pushed
the
rk/k8s-440/drop-configurator-image-from-values
branch
from
965c987 to
fdfe3ec
Compare
RafalKorepta
force-pushed
the
rk/k8s-440/drop-configurator-image-from-values
branch
from
fdfe3ec to
f2f94ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference
#368
K8S-440