cst: streaming parsing for tx range manifests #24728
Open
+316
−49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At 100k dom deserializer does large allocations
seastar_memory - oversized allocation: 2273280 bytes
while sax serializer never allocates more than 128k (this is actually the maximum allocation observed).Downsides: the parser is very rigid. We can't evolve the file in place. I doubt we care as we'd rather move to
tx2
file extension and binary serialization if we wanted to include additional information.PTAL
Backports Required
Release Notes