Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v24.2.x] rpk bundle: Fix race condition in SASL credential redaction #24730

Merged
merged 1 commit into from
Jan 8, 2025
Merged

[v24.2.x] rpk bundle: Fix race condition in SASL credential redaction #24730

merged 1 commit into from
Jan 8, 2025

Conversation

vbotbuildovich
Copy link
Collaborator

Backport of PR #24675

@r-vasquez @vbotbuildovich
rpk bundle: Fix race condition in SASL credential redaction
041790e 
This commit addresses a bug where SASL credentials
stored only in the redpanda.yaml could be redacted
before being used for authentication.

If the credentials were not provided elsewhere
(e.g. via environment variables or flags), the
redacted value would be used, leading to
authentication errors due to invalid credentials.

(cherry picked from commit 57dc975)
@vbotbuildovich vbotbuildovich added this to the v24.2.x-next milestone Jan 8, 2025
@vbotbuildovich vbotbuildovich added the kind/backport PRs targeting a stable branch label Jan 8, 2025
@vbotbuildovich
Copy link
Collaborator Author

Retry command for Build#60424

please wait until all jobs are finished before running the slash command

/ci-repeat 1
tests/rptest/tests/archive_retention_test.py::CloudArchiveRetentionTest.test_delete@{"cloud_storage_type":2,"retention_type":"retention.ms"}

@vbotbuildovich
Copy link
Collaborator Author

CI test results

test results on build#60424
test_id test_kind job_url test_status passed
rptest.tests.archive_retention_test.CloudArchiveRetentionTest.test_delete.cloud_storage_type=CloudStorageType.ABS.retention_type=retention.ms ducktape https://buildkite.com/redpanda/redpanda/builds/60424#0194470f-4438-4acd-8571-a885e1c9e688 FAIL 0/1
rptest.tests.random_node_operations_test.RandomNodeOperationsTest.test_node_operations.enable_failures=True.mixed_versions=True.with_tiered_storage=True ducktape https://buildkite.com/redpanda/redpanda/builds/60424#0194470a-280f-4c8c-90dc-66f03cad3fd1 FLAKY 5/6
test_kafka_protocol_unit_rpunit.test_kafka_protocol_unit_rpunit unit https://buildkite.com/redpanda/redpanda/builds/60424#019446c7-0f85-48fa-97e5-67fa29e61939 FLAKY 1/2

@r-vasquez r-vasquez merged commit cbd4de7 into redpanda-data:v24.2.x Jan 8, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r-vasquez r-vasquez r-vasquez approved these changes

@twmb twmb Awaiting requested review from twmb twmb is a code owner

@gene-redpanda gene-redpanda Awaiting requested review from gene-redpanda gene-redpanda is a code owner

@Deflaimun Deflaimun Awaiting requested review from Deflaimun Deflaimun is a code owner

Assignees
No one assigned
Labels
area/rpk kind/backport PRs targeting a stable branch
Projects
None yet
Milestone
v24.2.x-next
Development

Successfully merging this pull request may close these issues.
2 participants
@vbotbuildovich @r-vasquez