New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpk: add `rpk generate license` #24760

Open

r-vasquez wants to merge 1 commit into redpanda-data:dev from r-vasquez:rpk-generate-license

Contributor

r-vasquez commented Jan 9, 2025

This new command allows users to request a free trial license for 30 days using rpk

Backports Required

Release Notes

none


          rpk: add rpk generate license

33bb805

It uses the public API to request a free trial
license for 30 days.

r-vasquez requested review from twmb, gene-redpanda and Deflaimun as code owners

January 9, 2025 23:25

r-vasquez requested a review from sago2k8

January 9, 2025 23:26

github-actions bot added area/rpk area/build labels

Collaborator

vbotbuildovich commented Jan 10, 2025 •

edited

Loading

Retry command for Build#60551

please wait until all jobs are finished before running the slash command


/ci-repeat 1
tests/rptest/tests/cloud_storage_scrubber_test.py::CloudStorageScrubberTest.test_scrubber@{"cloud_storage_type":2}
tests/rptest/tests/archival_test.py::ArchivalTest.test_all_partitions_leadership_transfer@{"cloud_storage_type":1}

Collaborator

vbotbuildovich commented Jan 10, 2025

CI test results

test results on build#60551

test_id	test_kind	job_url	test_status	passed
rm_stm_tests_rpunit.rm_stm_tests_rpunit	unit	https://buildkite.com/redpanda/redpanda/builds/60551#01944d66-9cd0-4a0a-a551-41431e14675c	FLAKY	1/2
rm_stm_tests_rpunit.rm_stm_tests_rpunit	unit	https://buildkite.com/redpanda/redpanda/builds/60551#01944d66-9cd2-4644-a866-c85f59867b7c	FLAKY	1/2
rptest.tests.archival_test.ArchivalTest.test_all_partitions_leadership_transfer.cloud_storage_type=CloudStorageType.S3	ducktape	https://buildkite.com/redpanda/redpanda/builds/60551#01944dc3-824c-43f1-9511-b14b18f9703b	FAIL	0/1
rptest.tests.cloud_storage_scrubber_test.CloudStorageScrubberTest.test_scrubber.cloud_storage_type=CloudStorageType.ABS	ducktape	https://buildkite.com/redpanda/redpanda/builds/60551#01944dc1-e34e-4824-ba83-f8db8c769b2b	FAIL	0/1

Deflaimun reviewed

View reviewed changes

src/go/rpk/pkg/cli/generate/license.go

+              If you require a permanent license, contact us: https://www.redpanda.com/contact
+              The license will be saved in your working directory or the specified path, based
+              on the --path value.

Contributor

Deflaimun Jan 10, 2025

Suggested change

      
            on the --path value.
          
            on the --path flag.

Deflaimun reviewed

View reviewed changes

src/go/rpk/pkg/cli/generate/license.go

+              			err = rpkos.ReplaceFile(fs, savePath, []byte(signup.Msg.GetLicense().LicenseKey), 0o644)
+              			if err != nil {
+              				fmt.Printf(`
+              Successfully generated a license but we were unable to save it to a file: %v

Contributor

Deflaimun Jan 10, 2025

Does the user have access to this value somewhere?
If not, we should inform them somehow. Github for example has this message when you're creating a token "Make sure to copy your personal access token now. You won’t be able to see it again!"

we could add something to that extend, if that's true.

kbatuigas reviewed

View reviewed changes

src/go/rpk/pkg/cli/generate/license.go

+              		Short: "Generate a trial license",
+              		Long: `Generate a trial license
+              This command allows you to sign up for a 30 day trial of Redpanda Enterprise.

kbatuigas Jan 10, 2025

Suggested change

      
            This command allows you to sign up for a 30 day trial of Redpanda Enterprise.
          
            This command allows you to sign up for a 30-day trial of Redpanda Enterprise.

kbatuigas reviewed

View reviewed changes

src/go/rpk/pkg/cli/generate/license.go

+              		},
+              	}
+              	cmd.Flags().StringVar(&path, "path", "", "File path for generating the license")
+              	cmd.Flags().BoolVar(&noConfirm, "no-confirm", false, "Avoid confirmation prompt for overwriting the generated license file")

kbatuigas Jan 10, 2025 •

edited

Loading

Suggested change

      
            	cmd.Flags().BoolVar(&noConfirm, "no-confirm", false, "Avoid confirmation prompt for overwriting the generated license file")
          
            	cmd.Flags().BoolVar(&noConfirm, "no-confirm", false, "Do not show confirmation prompt for overwriting the generated license file")

For clarity - please check that the rephrase is correct.

kbatuigas reviewed

View reviewed changes

src/go/rpk/pkg/cli/generate/license.go

+              	cmd.Flags().StringVar(&path, "path", "", "File path for generating the license")
+              	cmd.Flags().BoolVar(&noConfirm, "no-confirm", false, "Avoid confirmation prompt for overwriting the generated license file")
+              	// License request info.
+              	cmd.Flags().StringVar(&lr.name, "name", "", "First name to register the trial license")

kbatuigas Jan 10, 2025 •

edited

Loading

Suggested change

      
            	cmd.Flags().StringVar(&lr.name, "name", "", "First name to register the trial license")
          
            	cmd.Flags().StringVar(&lr.name, "name", "", "First name for trial license registration")

For clarity

kbatuigas reviewed

View reviewed changes

src/go/rpk/pkg/cli/generate/license.go

+              	cmd.Flags().BoolVar(&noConfirm, "no-confirm", false, "Avoid confirmation prompt for overwriting the generated license file")
+              	// License request info.
+              	cmd.Flags().StringVar(&lr.name, "name", "", "First name to register the trial license")
+              	cmd.Flags().StringVar(&lr.lastname, "last-name", "", "Last name to register the trial license")

kbatuigas Jan 10, 2025

Suggested change

      
            	cmd.Flags().StringVar(&lr.lastname, "last-name", "", "Last name to register the trial license")
          
            	cmd.Flags().StringVar(&lr.lastname, "last-name", "", "Last name for register trial license registration")

kbatuigas reviewed

View reviewed changes

src/go/rpk/pkg/cli/generate/license.go

+              	// License request info.
+              	cmd.Flags().StringVar(&lr.name, "name", "", "First name to register the trial license")
+              	cmd.Flags().StringVar(&lr.lastname, "last-name", "", "Last name to register the trial license")
+              	cmd.Flags().StringVar(&lr.company, "company", "", "Company name to register the trial license")

kbatuigas Jan 10, 2025

Suggested change

      
            	cmd.Flags().StringVar(&lr.company, "company", "", "Company name to register the trial license")
          
            	cmd.Flags().StringVar(&lr.company, "company", "", "Company name for trial license registration")

kbatuigas reviewed

View reviewed changes

src/go/rpk/pkg/cli/generate/license.go

+              	cmd.Flags().StringVar(&lr.name, "name", "", "First name to register the trial license")
+              	cmd.Flags().StringVar(&lr.lastname, "last-name", "", "Last name to register the trial license")
+              	cmd.Flags().StringVar(&lr.company, "company", "", "Company name to register the trial license")
+              	cmd.Flags().StringVar(&lr.email, "email", "", "Company email to register the trial license")

kbatuigas Jan 10, 2025

Suggested change

      
            	cmd.Flags().StringVar(&lr.email, "email", "", "Company email to register the trial license")
          
            	cmd.Flags().StringVar(&lr.email, "email", "", "Company email for trial license registration")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

kbatuigas kbatuigas left review comments

Deflaimun Deflaimun left review comments

twmb Awaiting requested review from twmb twmb is a code owner

gene-redpanda Awaiting requested review from gene-redpanda gene-redpanda is a code owner

sago2k8 Awaiting requested review from sago2k8

At least 1 approving review is required to merge this pull request.

Labels

area/build area/rpk