Partition replicate API changes, follow up
#24771
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that the replicate interface is using `chunked_vector` we do not need an intermediate vector in `replicate_batcher` to count all records. Signed-off-by: Michał Maślanka <michal@redpanda.com>
Signed-off-by: Michał Maślanka <michal@redpanda.com>
mmaslankaprv
force-pushed
the
replicate-api-follow-up
branch
from
5e0a971 to
8ab9f50
Compare
mmaslankaprv
changed the title
replicate API changes, follow up
mmaslankaprv
requested review from
StephanDollberg,
bharathv,
ztlpn and
bashtanov
mmaslankaprv
force-pushed
the
replicate-api-follow-up
branch
from
8ab9f50 to
3411df9
Compare
Signed-off-by: Michał Maślanka <michal@redpanda.com>
Using `std::unique_ptr` wrapped batch in the produce request handlers make moving batch less expensive. Signed-off-by: Michał Maślanka <michal@redpanda.com>
mmaslankaprv
force-pushed
the
replicate-api-follow-up
branch
from
3411df9 to
0941085
Compare
|
lgtm but there is a compilation error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains another set of changes simplifying the
partitionreplicate API. Using a single batch API is convenient and makes replicating batches from Kafka API easier.Backports Required
Release Notes