implement apartment endpoint functionaltiy #274
Conversation
… ApartmentController two methods from BuildingController as well as the method from BuildingControllerTest to ApartmentControllerTest
…d ApartmentResource with methods (get & create). Corrected and complemented ApartmentEndpoint methods/annotations (create & get) & implemented valueOf method in ApartmentJson
…ty' into dev-apartmentEndpointFunctionality
…ed ApartmentEndpoint methods/annotations (update & delete)
…ence to ApartmentJson & changed legacy attribute rent to tenancy in TestData
…& tests in ApartmentRepositoryTest for the individually implemented repository methods
…mentResource and implemented REST assured tests for createApartment, deleteApartment, updateApartment in ApartmentResourceTest
|
unfortunately i cannot assign a reviewer. @XxILUSHAxX wants to review this pull request. |
|
Hello @F4c3hugg3r, |
|
@XxILUSHAxX I cannot add you as reviewer, because you are not part of the organization! Please accept my invitation! |
|
Hello @F4c3hugg3r as you might have noticed, our issues are very similiar in their structure and requirements. For my Issue, there is also a need for Tenancy Test-Data, which you already have implemented (see here). Because i want to avoid any merge conflicts or cause any test-errors for both of us, i would like to take the same Test-Data for Tenancy you used. Is that okay with you? |
|
That's completely fine with me @XxILUSHAxX |
There was a problem hiding this comment.
The implementation is well done. All the requirements of the issue have been solved. Your implementation is really well done and the project runs with no issues. There is one small things which needs correction (see the comment) but other than that your solution for this issue is fullfilled.
remsfal-service/src/test/java/de/remsfal/service/entity/ApartmentRepositoryTest.java
Outdated
Show resolved
Hide resolved
|
Referring to this issue