Shortcuts for Sub-Resources #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ArniBananii Can you please make your review for this Pull Request? |
astanik
force-pushed
the
275-shortcut-for-subresources
branch
from
929a742 to
e39c104
Compare
|
@ArniBananii This is my last request for your review! |
ArniBananii
reviewed
Jan 6, 2025
remsfal-core/src/main/java/de/remsfal/core/api/project/BuildingEndpoint.java
Show resolved
Hide resolved
| @Override | ||
| public ApartmentEndpoint getApartmentResource() { | ||
| // TODO Auto-generated method stub | ||
| return null; |
There was a problem hiding this comment.
Why are we overriding the method to let it return null? An explenation could really help here.
| } | ||
|
|
||
| @Override | ||
| public ApartmentEndpoint getApartmentResource() { |
astanik
force-pushed
the
275-shortcut-for-subresources
branch
from
e39c104 to
0d8373f
Compare
astanik
force-pushed
the
275-shortcut-for-subresources
branch
from
0d8373f to
c43c74d
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.