#265 Implementierung des Garage Endpoints mit CRUD-Funktionalität #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RemodifyBerlin
suggested changes
Dec 29, 2024
There was a problem hiding this comment.
Overall, this is a great job!
The code is well-organized, and the functionality is clear. There are only a few minor issues to tidy up (or check) before merging—for example, some duplicated code and slight naming inconsistencies. With a quick cleanup, the code will be easier to maintain in the future. Then you should be good to go to merge!
remsfal-service/src/main/java/de/remsfal/service/boundary/project/GarageResource.java
Show resolved
Hide resolved
remsfal-service/src/main/java/de/remsfal/service/control/GarageController.java
Show resolved
Hide resolved
remsfal-service/src/test/java/de/remsfal/service/boundary/project/GarageResourceTest.java
Outdated
Show resolved
Hide resolved
remsfal-service/src/test/java/de/remsfal/service/control/GarageControllerTest.java
Outdated
Show resolved
Hide resolved
|
RemodifyBerlin
approved these changes
Jan 6, 2025
RemodifyBerlin
approved these changes
Jan 6, 2025
astanik
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR implements the
Garageendpoint, providing full CRUD functionality as defined in Issue #265Key Changes
GarageEndpoint,GarageJson, andGarageModelwith specified attributesGarageResource,GarageController,GarageRepository, andGarageEntityfor managing Garage dataThis ensures full CRUD operations for the Garage Entity with proper definitions and database integration