-
-
Notifications
You must be signed in to change notification settings - Fork 559
fix Chinese and English mixing #237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@chai51 I'm not sure I understand what exactly this is trying to fix and how/what it fixes? |
Purely a guess on my part, but I think this is a request for support for "Kokoro-82M-v1.1-zh" which is supposed to be better with at least Chinese, and which only handles Chinese and English. |
When the Voice is set to zf_xiaoyi and the Language is set to Chinese, it is illustrated by the following two use cases: |
@chai51 So what your saying is that if the language is Chinese instead of loading the normal kokoro v1 model it loads kokoro v1.1. Some questions are:
|
Yeah, you're right.
|
Hey, this is a must have fix for text with mixed Chinese and English words. When can this PR be merged? It seems there is not code conflicts. |
Has the code been merged? I also have a need for a mix of Chinese and English |
Could someone help to merge it? Thanks! |
Does the author identify the changes trying to fix mixed Chinese and English words and plan to merge the branch? Please take time on this |
@fireblade2534 is there any barrier block this PR? If not, could you please merge this PR? It's very important for scenario with mixed Chinese and English words. |
The original code can support pure Chinese pronunciation very well, but when it comes to mixed Chinese and English pronunciation, the English pronunciation data will be lost.
I have improved this function. However, the download_model.py is missing because there is no download address for
Kokoro-82M-v1.1-zh
in the release.#214