Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't import importlib_metadata since Py3.8 already has it as importlib.metadata #52

Merged
merged 1 commit into from
Dec 15, 2024
Merged

Don't import importlib_metadata since Py3.8 already has it as importlib.metadata #52

merged 1 commit into from
Dec 15, 2024

Conversation

akosthekiss
Copy link
Collaborator

It has already been dropped from setup.cfg.

@akosthekiss
Don't import importlib_metadata since Py3.8 already has it as importl…
b4cdec0 
…ib.metadata

It has already been dropped from setup.cfg.
@coveralls
Copy link

Coverage Status

coverage: 93.265% (+0.3%) from 93.003%
when pulling b4cdec0 on akosthekiss:importlib-metadata
into d2871f2 on renatahodovan:master.

renatahodovan
renatahodovan approved these changes Dec 15, 2024
View reviewed changes
Copy link
Owner

@renatahodovan renatahodovan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@renatahodovan renatahodovan merged commit 34037bc into renatahodovan:master Dec 15, 2024
25 checks passed
@akosthekiss akosthekiss deleted the importlib-metadata branch December 15, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renatahodovan renatahodovan renatahodovan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akosthekiss @coveralls @renatahodovan