Skip to content

Return false for integration.IsEnabled if key unset in replicated secret #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Return false for integration.IsEnabled if key unset in replicated secret #139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
55c5d4c
Update integration.go
dexhorthy Jan 27, 2024
d53c88b
Fix unit tests
divolgin Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/integration/integration.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ func IsEnabled(ctx context.Context, clientset kubernetes.Interface, namespace st

v, ok := secret.Data[integrationEnabledKey]
if !ok || len(v) == 0 {
return true, nil
return false, nil
}

enabled, _ := strconv.ParseBool(string(v))
Expand Down
4 changes: 2 additions & 2 deletions pkg/integration/integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ func TestIntegration_IsEnabled(t *testing.T) {
},
},
},
want: true,
want: false,
wantErr: false,
},
{
Expand All @@ -163,7 +163,7 @@ func TestIntegration_IsEnabled(t *testing.T) {
},
},
},
want: true,
want: false,
wantErr: false,
},
}
Expand Down
Loading