Basic MultiVersion Fabric support #1156
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when calling optimized decode() MethodHandle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current setup produces very small jars (~15 kb extra per version we explicitly build against) but its rather unwieldy and hacky with static setting static fields and poor usage of lazy loaders.
I would like to fix this but the ideal solution would require breaking code that makes direct calls to the
PacketEventsMod*classes and I'm unsure whether or not that's considered acceptable (IE considered internal code).This setup has been tested and is fully working on 1.20.1, 1.21.1, and 1.21.4. Versions in-between have not been tested but are likely to work.
Proceeded by: #1154