-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ceph-exporter: add support for launching the exporter daemon #89
base: main
Are you sure you want to change the base?
ceph-exporter: add support for launching the exporter daemon #89
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not use this dev env usually, but changes seems correct to me.
And as it can be seen in the video included in:
ceph/ceph#60623
It works perfectly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on this comment, we should make changes to this PR as well.
fba1522
to
19ab767
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
19ab767
to
552688b
Compare
Can we get this merged? @epuertat @cloudbehl @jmolmo |
552688b
to
75d328c
Compare
Signed-off-by: Piyush Agarwal <piyushagarwal14.pa@gmail.com>
75d328c
to
5ed6f2c
Compare
This PR adds support for optionally launching the
ceph-exporter
daemon in the Ceph environment setup. A new--exporter
command-line option is introduced to thevstart.sh
script (ceph/ceph#60623), allowing users to enable or disable the exporter daemon. The changes include:docker-compose.yml
:EXPORTER
with a default value of0
. The variable can be set to1
to enable the exporter.docker/ceph/rpm/Dockerfile
:ceph-exporter
in the Docker image by adding it to thednf install
command, ensuring that the exporter daemon is available in the container.docker/ceph/set-start-env.sh
:EXPORTER
flag. If set to1
, the--exporter
option is added to theVSTART_OPTIONS
, triggering the startup of the exporter daemon when the environment is initialized.docker/prometheus/ceph-exporter-targets.yml
(new file):ceph-exporter
targets for Prometheus scraping.docker/prometheus/prometheus.yml
:ceph-exporter
by adding a new job for the exporter and using theceph-exporter-targets.yml
file for the target configuration.