-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for choosing different kernels on aarch64 #41
Support for choosing different kernels on aarch64 #41
Conversation
As this introduces a new option for anabot recipes, the documentation will need to be updated as well either once the PR #40 closes, or as a part of it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dane, thank you for implementing the new functionality! It looks fine, I'd only suggest to improve the action results handling a bit.
2c0484a
to
babba54
Compare
Link to beaker jobs testing this functionality are in Jira :) RTT-5270 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@You-never-know Dane, thank you for the fixes and sorry for the delay. Please have a look at NotFoundResult
handling (other than that there are a few more suggestions for improvement, though not critical).
BTW, I forgot one thing - please document the changes in recipe elements documentation. |
@jikortus Thank you for the review and suggestions, I will look into them and improve the code. |
babba54
to
cd51fac
Compare
26d4016
to
4c47778
Compare
4c47778
to
b691c8f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dane, thank you for implementing my suggestions. I have an idea about how you might fix the translation (not sure, just an idea), you could give it a try if it doesn't take too much time. Other than that there are a few small details, overall I like how the code looks like :-).
b691c8f
to
e34aa60
Compare
@You-never-know Awesome, I'm glad you were successful in fighting the translation issue :-). Thank you for the code! |
This new feature allows users to choose the kernel option on aarch64. It is needed for automatic tests.