Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for choosing different kernels on aarch64 #41

Merged
merged 3 commits into from
Nov 29, 2023

Conversation

You-never-know
Copy link
Contributor

This new feature allows users to choose the kernel option on aarch64. It is needed for automatic tests.

@You-never-know
Copy link
Contributor Author

As this introduces a new option for anabot recipes, the documentation will need to be updated as well either once the PR #40 closes, or as a part of it.

@You-never-know
Copy link
Contributor Author

@jikortus @jstodola I believe, you are the best people to review these changes once you have time for it. :)

Copy link
Contributor

@jikortus jikortus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dane, thank you for implementing the new functionality! It looks fine, I'd only suggest to improve the action results handling a bit.

anabot/runtime/installation/hub/software_selection.py Outdated Show resolved Hide resolved
anabot/runtime/installation/hub/software_selection.py Outdated Show resolved Hide resolved
anabot/runtime/installation/hub/software_selection.py Outdated Show resolved Hide resolved
anabot/runtime/installation/hub/software_selection.py Outdated Show resolved Hide resolved
anabot/runtime/installation/hub/software_selection.py Outdated Show resolved Hide resolved
@You-never-know
Copy link
Contributor Author

Link to beaker jobs testing this functionality are in Jira :) RTT-5270

Copy link
Contributor

@jikortus jikortus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@You-never-know Dane, thank you for the fixes and sorry for the delay. Please have a look at NotFoundResult handling (other than that there are a few more suggestions for improvement, though not critical).

anabot/runtime/installation/hub/software_selection.py Outdated Show resolved Hide resolved
anabot/runtime/installation/hub/software_selection.py Outdated Show resolved Hide resolved
anabot/runtime/installation/hub/software_selection.py Outdated Show resolved Hide resolved
anabot/runtime/installation/hub/software_selection.py Outdated Show resolved Hide resolved
@jikortus
Copy link
Contributor

BTW, I forgot one thing - please document the changes in recipe elements documentation.

@You-never-know
Copy link
Contributor Author

@jikortus Thank you for the review and suggestions, I will look into them and improve the code.

Copy link
Contributor

@jikortus jikortus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dane, thank you for implementing my suggestions. I have an idea about how you might fix the translation (not sure, just an idea), you could give it a try if it doesn't take too much time. Other than that there are a few small details, overall I like how the code looks like :-).

anabot/runtime/installation/hub/software_selection.py Outdated Show resolved Hide resolved
anabot/runtime/installation/hub/software_selection.py Outdated Show resolved Hide resolved
doc/recipe_elements/software_selection.rst Outdated Show resolved Hide resolved
doc/recipe_elements/software_selection.rst Outdated Show resolved Hide resolved
doc/recipe_elements/software_selection.rst Outdated Show resolved Hide resolved
@jikortus
Copy link
Contributor

@You-never-know Awesome, I'm glad you were successful in fighting the translation issue :-). Thank you for the code!

@jikortus jikortus merged commit 3a6e08e into rhinstaller:main Nov 29, 2023
@You-never-know You-never-know deleted the arm-kernel-64k-support branch November 30, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants