Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for LUKS device unlock #42

Merged
merged 4 commits into from
Nov 21, 2023
Merged

Add support for LUKS device unlock #42

merged 4 commits into from
Nov 21, 2023

Conversation

jikortus
Copy link
Contributor

There's a new element for LUKS devices unlocking (/installation/hub/partitioning/advanced/details/luks_unlock). I used the disk rescan functionality as part of testing and found out there are missing/malfunctioning handlers for it, so I decided to also fix them. Test jobs will be linked in RTT-5231.

So far the base handler called default_handler() with a fixed
local node (page tab containing details about selected device).
The local node may, however, become invalid under some circumstances,
for example when a LUKS device is unlocked.

To fix this, it's needed to check that the local node is still
valid before executing a particular handler/check, and update
it to a new one if needed.
@jikortus jikortus requested a review from jstodola November 20, 2023 15:17
The reason is to enable use of the function also
within details.py.
Copy link
Collaborator

@jstodola jstodola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jstodola jstodola merged commit 0db0f38 into main Nov 21, 2023
5 checks passed
@jstodola jstodola deleted the luks_unlock branch November 21, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants