Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Anaconda WebUI plugin to reflect changes made in anaconda repo #78

Merged
merged 2 commits into from
Dec 13, 2023

Conversation

velezd
Copy link
Collaborator

@velezd velezd commented Nov 27, 2023

No description provided.

@velezd velezd marked this pull request as ready for review November 27, 2023 13:30
@velezd velezd requested a review from jstodola November 27, 2023 13:48
jstodola
jstodola previously approved these changes Nov 28, 2023
Copy link
Contributor

@jstodola jstodola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

``anaconda/ui/webui/test/common`` exists, this repo won't be used.
- **webui_repo** - URL to anaconda-webui git repository or path to local directory (use file://)
- **cockpit_repo** - URL to Cockpit git repository, if webui_repo is local directory and
``./test/common`` exists, this repo won't be used.
- **cockpit_branch** - Cockpit git branch
- **bots_repo** - URL to Cockpit Bots git repository, if anaconda_repo is local directory and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"anaconda_repo" should be replaced with "webui_repo"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is, or am I missing something?

libpermian/plugins/anaconda_webui/commands.py Outdated Show resolved Hide resolved
Copy link
Contributor

@jstodola jstodola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@velezd velezd merged commit cbc513d into devel Dec 13, 2023
4 checks passed
@velezd velezd deleted the awebui_update branch December 13, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants