Skip to content

gdb: Bump to next major version. #1710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Arielfoever
Copy link
Contributor

No description provided.

@Arielfoever
Copy link
Contributor Author

[ariel@archlinux bin]$ ./riscv64-unknown-linux-gnu-gcc -v
Using built-in specs.
COLLECT_GCC=./riscv64-unknown-linux-gnu-gcc
COLLECT_LTO_WRAPPER=/home/ariel/toolchain/res/libexec/gcc/riscv64-unknown-linux-gnu/15.1.1/lto-wrapper
Target: riscv64-unknown-linux-gnu
Configured with: /home/ariel/toolchain/riscv-gnu-toolchain/gcc/configure --target=riscv64-unknown-linux-gnu --prefix=/home/ariel/toolchain/res --with-sysroot=/home/ariel/toolchain/res/sysroot --with-pkgversion=g4b0d25e7262 --with-system-zlib --enable-shared --enable-tls --enable-languages=c,c++,fortran --disable-libmudflap --disable-libssp --disable-libquadmath --disable-libsanitizer --disable-nls --disable-bootstrap --src=.././gcc --disable-default-pie --disable-multilib --with-abi=lp64d --with-arch=rv64gc --with-tune=rocket --with-isa-spec=20191213 'CFLAGS_FOR_TARGET=-O2    -mcmodel=medlow' 'CXXFLAGS_FOR_TARGET=-O2    -mcmodel=medlow'
Thread model: posix
Supported LTO compression algorithms: zlib zstd
gcc version 15.1.1 20250426 (g4b0d25e7262) 

@kito-cheng
Copy link
Collaborator

@Arielfoever Thanks for the PR, could you add few more info in the commit log, e.g. bump gcc and gdb to which version, also the branch in the .gitmodules need to updated, and last, could you separate that into 2 commit.

:)

@Arielfoever
Copy link
Contributor Author

@Arielfoever Thanks for the PR, could you add few more info in the commit log, e.g. bump gcc and gdb to which version, also the branch in the .gitmodules need to updated, and last, could you separate that into 2 commit.

:)

Done.

@TommyMurphyTM1234
Copy link
Collaborator

Why is the GDB submodule change in this PR...

2025-04-30 15 15 14

not like the previous one that bumped it?

2025-04-30 15 14 32

@Arielfoever
Copy link
Contributor Author

Arielfoever commented Apr 30, 2025

Why is the GDB submodule change in this PR...

2025-04-30 15 15 14

not like the previous one that bumped it?

* https://github.com/riscv-collab/riscv-gnu-toolchain/pull/1593/files

2025-04-30 15 14 32

Bumped to gdb16 not gdb 15

[ariel@archlinux bin]$ ./riscv64-unknown-linux-gnu-gdb --version
GNU gdb (GDB) 16.3.90.20250426-git
Copyright (C) 2024 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

@TommyMurphyTM1234
Copy link
Collaborator

Bumped to gdb16 not gdb 15

Yes, but why is the change to the GDB submodule different this time to the last. Why doesn't it just show that the commit used has changed? Why does it say that 4,727 files were updated? That doesn't seem correct.

@Arielfoever
Copy link
Contributor Author

Bumped to gdb16 not gdb 15

Yes, but why is the change to the GDB submodule different this time to the last. Why doesn't it just show that the commit used has changed? Why does it say that 4,727 files were updated? That doesn't seem correct.

Oh god, that's quiet strange. I get this
图片
When I go to https://github.com/riscv-collab/riscv-gnu-toolchain/pull/1710/files

@Arielfoever
Copy link
Contributor Author

Arielfoever commented Apr 30, 2025

I guess the problem is in 400789a


Tested via Arielfoever@19e20b1 It tells us we need to revert 400789a or this problems occurs. Can someone tell me the principle?

@TommyMurphyTM1234
Copy link
Collaborator

Can someone tell me the principle?

Did you rebase your changes to take account of this PR

and so that your PR is with respect to the current top of tree and up to date with that PR's change of repo for certain submodules - including GDB?

@TommyMurphyTM1234
Copy link
Collaborator

e.g. bump gcc and gdb to which version, also the branch in the .gitmodules need to updated, and last, could you separate that into 2 commit.

Wasn't this a request to do two separate PRs to bump GCC and GDB separately?

@Arielfoever
Copy link
Contributor Author

Can someone tell me the principle?

Did you rebase your changes to take account of this PR

* [Use github's mirror for sourceware's repo #1702](https://github.com/riscv-collab/riscv-gnu-toolchain/pull/1702)

and so that your PR is with respect to the current top of tree and up to date with that PR's change of repo for certain submodules - including GDB?

yes I rebase it.

This branch is 2 commits ahead of riscv-collab/riscv-gnu-toolchain:master

@Arielfoever
Copy link
Contributor Author

e.g. bump gcc and gdb to which version, also the branch in the .gitmodules need to updated, and last, could you separate that into 2 commit.

Wasn't this a request to do two separate PRs to bump GCC and GDB separately?

emmm I think no and no need

could you separate that into 2 commit.

@TommyMurphyTM1234
Copy link
Collaborator

It tells us we need to revert 400789a

I don't think that this commit/PR should be reverted as it fixes the "shallow clone" problem that has been an issue for a while now. And it works and the CI builds and test suite runs work so the PR is perfectly correct.

I think that this current PR needs to be modified to fix the seeming problem with bumping GDB.

I would also agree with @kito-cheng that it's better to bump submodules individually so have separate PRs to bump GCC and GDB.

Signed-off-by: Ariel Xiong <ArielHeleneto@outlook.com>
@Arielfoever Arielfoever changed the title gcc, gdb: Bump to next major version. gdb: Bump to next major version. May 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants