Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(storage): use VecDeque for TableChangeLog to avoid large clone on truncate #19984

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

wenym1
Copy link
Contributor

@wenym1 wenym1 commented Jan 2, 2025

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

May alleviate the issue mentioned in #19960.

Previously we use Vec to store all table change log. When applying version delta, we use Vec::retain to clean the stale change log. However, for subscription with large retention time, the Vec can be large, and the Vec::retain called in truncate will incur great cost. In this PR, we change to use VecDeque to store the change log, so that the cost of truncate will reduce from O(N) to O(1).

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@wenym1 wenym1 requested review from hzxa21, Li0k and zwang28 January 2, 2025 06:40
Copy link
Contributor

@zwang28 zwang28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Li0k Li0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Li0k Li0k enabled auto-merge January 2, 2025 07:54
@Li0k Li0k added this pull request to the merge queue Jan 2, 2025
Merged via the queue into main with commit 5cb0d17 Jan 2, 2025
39 of 40 checks passed
@Li0k Li0k deleted the yiming/vecdeque-table-change-log branch January 2, 2025 10:20
github-actions bot pushed a commit that referenced this pull request Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants