perf(storage): use VecDeque for TableChangeLog to avoid large clone on truncate #19984
+78
−60
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
May alleviate the issue mentioned in #19960.
Previously we use
Vec
to store all table change log. When applying version delta, we useVec::retain
to clean the stale change log. However, for subscription with large retention time, theVec
can be large, and theVec::retain
called intruncate
will incur great cost. In this PR, we change to useVecDeque
to store the change log, so that the cost oftruncate
will reduce fromO(N)
toO(1)
.Checklist
Documentation
Release note