Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(mysql-cdc): add retry when connecting to mysql #20043

Open
wants to merge 1 commit into
base: release-2.1
Choose a base branch
from
Open

feat(mysql-cdc): add retry when connecting to mysql #20043

wants to merge 1 commit into from
+42 −1

Conversation

wenym1
Copy link
Contributor

@wenym1 wenym1 commented Jan 7, 2025 •
edited by StrikeW
Loading

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

The PR is just for review and no need to merge

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@graphite-app graphite-app bot requested a review from lmatz January 7, 2025 05:51
@graphite-app Graphite App
Copy link

graphite-app bot commented Jan 7, 2025

Graphite Automations

"release branch request review" took an action on this PR • (01/07/25)

1 reviewer was added to this PR based on xxchan's automation.

@lmatz lmatz requested a review from StrikeW January 7, 2025 09:42
StrikeW
StrikeW reviewed Jan 7, 2025
View reviewed changes
Copy link
Contributor

@StrikeW StrikeW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StrikeW StrikeW StrikeW left review comments

@lmatz lmatz lmatz approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
type/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wenym1 @lmatz @StrikeW