Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connctor): fix file scan s3 access issue in release-2.2 #20081

Open
wants to merge 2 commits into
base: release-2.2
Choose a base branch
from

Conversation

wcy-fdu
Copy link
Contributor

@wcy-fdu wcy-fdu commented Jan 9, 2025

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

The bug is miss previously overlooked because builder = builder.disable_config_load(); was not added. As a result, during local testing, it was able to access S3 normally since it was reading from the local AWS environment variables.
In other words, if the AWS config is correctly configured locally, it can also be read normally.

The main branch has already been fixed.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@wcy-fdu wcy-fdu requested review from hzxa21 and zwang28 January 9, 2025 05:50
@graphite-app graphite-app bot requested a review from lmatz January 9, 2025 06:43
Copy link

graphite-app bot commented Jan 9, 2025

Graphite Automations

"release branch request review" took an action on this PR • (01/09/25)

1 reviewer was added to this PR based on xxchan's automation.

@wcy-fdu wcy-fdu added this pull request to the merge queue Jan 10, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants