Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fail fast sqllogictest #20087

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

ci: fail fast sqllogictest #20087

wants to merge 3 commits into from

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Jan 9, 2025

risinglightdb/sqllogictest-rs#246
The motivation is that currently when test failed, the end of the log is usually some error like "table not found", and we need to scroll up to find the real error.

image

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

The motivation is that currently when test failed, the end of the log is usually some error like "table not found", and we need to scroll up to find the real error.

Signed-off-by: xxchan <xxchan22f@gmail.com>
@xxchan xxchan marked this pull request as ready for review January 10, 2025 14:44
@xxchan xxchan requested a review from a team as a code owner January 10, 2025 14:44
@xxchan xxchan requested a review from MrCroxx January 10, 2025 14:44
@xxchan xxchan enabled auto-merge January 10, 2025 14:44
@xxchan xxchan requested a review from BugenZhao January 10, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant