refactor(meta): optimize Hummock version delta deletion #20114
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
This PR removes the unnecessary clone during
delete_version_deltas
. The clone may has significant impact on the performance if the number ofhummock_version_deltas
is large. In the worst case, deletinghummock_version_deltas
can be slower than adding new ones, leading to a backlog ofhummock_version_deltas
.This PR also add logs to help monitor the progresss of Hummock version redo during startup. It's helpful for troubleshooting when there're lots of
hummock_version_deltas
and the redo is slow.This PR also move time travel metadata GC to dedicated tokio task.
Checklist
Documentation
Release note