DaisyUI v5 Theme for React JSON Schema Form v6 #4551
+906,788
−4,814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redesigned form templates with connected card styling, consistent spacing, and improved layout. Added proper visual hierarchy for nested elements, optimized control button positioning, and implemented cross-browser date/time widgets. Applied DaisyUI utility classes consistently for a cohesive interface while maintaining full RJSF functionality.
inchoate
commented
Apr 5, 2025
inchoate
changed the title
heath-freenome
requested changes
Apr 7, 2025
packages/daisyui/src/widgets/CheckboxesWidget/CheckboxesWidget.tsx
Outdated
Show resolved
Hide resolved
PR feedback. PR review
|
Looking good.
|
|
@heath-freenome - ready, sir. |
packages/daisyui/src/templates/ArrayFieldDescriptionTemplate/ArrayFieldDescriptionTemplate.tsx
Outdated
Show resolved
Hide resolved
packages/daisyui/src/templates/ArrayFieldTemplate/ArrayFieldTemplate.tsx
Outdated
Show resolved
Hide resolved
packages/daisyui/src/templates/WrapIfAdditionalTemplate/WrapIfAdditionalTemplate.tsx
Outdated
Show resolved
Hide resolved
packages/daisyui/src/templates/WrapIfAdditionalTemplate/WrapIfAdditionalTemplate.tsx
Outdated
Show resolved
Hide resolved
|
@heath-freenome I think we're closer now.
Core Rating Widget
Default Style
Daisy Style ❤️
|
packages/daisyui/src/templates/ArrayFieldDescriptionTemplate/ArrayFieldDescriptionTemplate.tsx
Outdated
Show resolved
Hide resolved
packages/daisyui/src/templates/ArrayFieldDescriptionTemplate/ArrayFieldDescriptionTemplate.tsx
Outdated
Show resolved
Hide resolved
packages/daisyui/src/templates/ArrayFieldTemplate/ArrayFieldTemplate.tsx
Outdated
Show resolved
Hide resolved
|
@inchoate you have a build error to fix with linting. Consider running |
Fixes selects. Uses Fieldsets instead of custom arrays. Uses join for buttons when appropriate. Calendar fix
packages/daisyui/src/templates/ArrayFieldTemplate/ArrayFieldTemplate.tsx
Outdated
Show resolved
Hide resolved
packages/daisyui/src/templates/FieldHelpTemplate/FieldHelpTemplate.tsx
Outdated
Show resolved
Hide resolved
packages/daisyui/src/templates/DescriptionField/DescriptionField.tsx
Outdated
Show resolved
Hide resolved
packages/daisyui/tailwind.config.js
Outdated
| @@ -0,0 +1,20 @@ | |||
| /** @type {import('tailwindcss').Config} */ | |||
There was a problem hiding this comment.
So I'm guessing this is working without the conversion
* Updated .github templates to add: fluent-rc, shadcn, daisy * Addresses all PR comments * Updates README
Comment on lines
+34
to
+37
| const onCopyClick = useMemo(() => onCopyIndexClick(index), [index, onCopyIndexClick]); | ||
| const onRemoveClick = useMemo(() => onDropIndexClick(index), [index, onDropIndexClick]); | ||
| const onArrowUpClick = useMemo(() => onReorderClick(index, index - 1), [index, onReorderClick]); | ||
| const onArrowDownClick = useMemo(() => onReorderClick(index, index + 1), [index, onReorderClick]); |
There was a problem hiding this comment.
You could switch these to useCallback() instead
packages/daisyui/src/templates/BaseInputTemplate/BaseInputTemplate.tsx
Outdated
Show resolved
Hide resolved
packages/daisyui/src/widgets/CheckboxesWidget/CheckboxesWidget.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate DaisyUI v5 with RJSF v6
This PR integrates DaisyUI v5 with React JSON Schema Form v6, providing a complete theme implementation with enhanced visual styling and component architecture.
Changes
nested.tsto enhance the demoTesting
Tested across multiple browsers with complex nested schemas including:
Screenshots
@heath-freenome @saadeghi