improve object iteration #30
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I get some very different results, so I'm rather hesitant to change any of those right now. |
|
i created a benchmark on another platform, https://jsbench.me/a4lpr3txxo/1 |
|
I get the same results over there. I think it's more about browser differences than the actual benchmark. I use Safari, most likely different in Firefox and/or Chrome. |
|
yeah, checked it on M1 in Safari. It seems faster, will investigate further into this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the benchmark (https://jsben.ch/kxBxv), the "for in" loop appears to be 10% slower than the "for" loop.
This pull request optimizes object traversal loops.
Also ESLint errors fixed.