Skip to content

ROB-1022 coralogix toolset returns url #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Apr 9, 2025

Conversation

nherment
Copy link
Collaborator

@nherment nherment commented Apr 8, 2025

Some improvements to coralogix:

  • The log tool returns
    • A URL to replicate the query on the coralogix UI
    • The dataprime query
  • The log level param has been removed. I'm not sure Holmes would use it well today and other logs toolsets don't support it. We may introduce it later if we find that Holmes need to quickly narrow down on errors although that may be solved better with an additional grep-like filter as opposed to log-level.
  • The default time window for logs is extended to 24hrs. This is to help Holmes get logs when investigating pod related issues and the pod has been deleted.

⚠️ should be merged after #365 because this branch was forked off of #365.

@nherment nherment enabled auto-merge (squash) April 9, 2025 09:18
@nherment nherment requested a review from moshemorad April 9, 2025 10:18
Copy link

github-actions bot commented Apr 9, 2025

Results of HolmesGPT evals

Test suite Test case Status
ask_holmes 01_how_many_pods ⚠️
ask_holmes 02_what_is_wrong_with_pod
ask_holmes 02_what_is_wrong_with_pod_LOKI
ask_holmes 03_what_is_the_command_to_port_forward
ask_holmes 04_related_k8s_events
ask_holmes 05_image_version
ask_holmes 06_explain_issue
ask_holmes 07_high_latency
ask_holmes 07_high_latency_LOKI
ask_holmes 08_sock_shop_frontend
ask_holmes 09_crashpod
ask_holmes 10_image_pull_backoff
ask_holmes 11_init_containers
ask_holmes 12_job_crashing
ask_holmes 12_job_crashing_LOKI
ask_holmes 13_pending_node_selector
ask_holmes 14_pending_resources
ask_holmes 15_failed_readiness_probe
ask_holmes 16_failed_no_toolset_found
ask_holmes 17_oom_kill
ask_holmes 18_crash_looping_v2
ask_holmes 19_detect_missing_app_details
ask_holmes 20_long_log_file_search
ask_holmes 20_long_log_file_search_LOKI
ask_holmes 21_job_fail_curl_no_svc_account ⚠️
ask_holmes 22_high_latency_dbi_down ⚠️
ask_holmes 23_app_error_in_current_logs
ask_holmes 23_app_error_in_current_logs_LOKI
ask_holmes 24_misconfigured_pvc
ask_holmes 25_misconfigured_ingress_class ⚠️
ask_holmes 26_multi_container_logs
ask_holmes 27_permissions_error_no_helm_tools
ask_holmes 28_permissions_error_helm_tools_enabled
ask_holmes 29_events_from_alert_manager
ask_holmes 30_basic_promql_graph_cluster_memory
ask_holmes 31_basic_promql_graph_pod_memory
ask_holmes 32_basic_promql_graph_pod_cpu
ask_holmes 33_http_latency_graph ⚠️
ask_holmes 34_memory_graph
ask_holmes 35_tempo
ask_holmes 37_argocd_wrong_namespace ⚠️
investigate 01_oom_kill
investigate 02_crashloop_backoff
investigate 03_cpu_throttling
investigate 04_image_pull_backoff
investigate 05_crashpod
investigate 05_crashpod_LOKI
investigate 06_job_failure ⚠️
investigate 07_job_syntax_error
investigate 08_memory_pressure
investigate 09_high_latency
investigate 10_kube_controller_manager_down ⚠️
investigate 11_KubeDeploymentReplicasMismatch
investigate 12_KubePodCrashLooping
investigate 13_KubePodNotReady
investigate 14_Watchdog
investigate 15_tempo

Legend

  • ✅ the test was successful
  • ⚠️ the test failed but is known to be flakky or known to fail
  • ❌ the test failed and should be fixed before merging the PR

@nherment nherment merged commit 3044548 into master Apr 9, 2025
12 checks passed
@nherment nherment deleted the ROB-1022_coralogix_toolset_returns_url branch April 9, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants