-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pooch
for testdata management, modernize
#261
base: master
Are you sure you want to change the base?
Conversation
…ct to birdhouse-raven, update pre-commit
@Zeitsperre the rook tests are using a generated Line 22 in f9d0638
|
Still using pandas < 2.0 and sqlalchemy < 2.0. I probably also need to update the intake catalogs which we are using. And the CDS needs to update as well. Maybe we can handle this in separate PR series. |
@cehbrecht Agreed. I think that some of the work in here can be reused, but there's a lot to sort out first with the underlying libraries. My priorities are to get Once the dust has settled, it'll be much easier to bring this service up to speed. |
Overview
Changes:
clisops
testing utilities andpytest
fixtures.gitpython
:mini-esgf-data
is now managed by theclisops
setup code.birdhouse-rook
name in preparation for a release of this library on PyPIruff
(faster, more modern).pyprojec.toml
file.Related Issue / Discussion
Some of these changes are being made to ensure that projects using the
mini-esgf-data
repository can make use of the new layout usingpooch
(see therestructuring
/v1
branches). Once this has been done, we can start using a versioned approach to test data collection and management (withpooch
and thestratus
class fromclisops
).I've also renamed the library to
birdhouse-rook
(rook
was taken on PyPI). This is no different from a few otherbirdhouse
projects that have been added toPyPI
(birdhouse-raven
,birdhouse-finch
). This name does not impact the existing module name (stillrook
), so no changes will be needed when using it as a library.Additional Information
@cehbrecht
My changes seem to have affected some of the configuration defaults. My theory is that there are some hard-coded filepaths that are causing the
FileNotFound
errors. If you could point me in the right direction, I would be willing to make the final adjustments here.It also appears that the
db
code is fully deprecated. We will need to update the SQL handling here to be able to support moderndaops
andpandas
.