Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scripts/config.{guess,sub} from autoconf v2.72 #111

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

robert-scheck
Copy link
Contributor

Add support for riscv64 by updating scripts/config.{guess,sub} from autoconf v2.72, which currently fails with:

checking build system type... ./config.guess: unable to guess system type

References:

Full build failure:

[…]
checking build system type... ./config.guess: unable to guess system type

This script, last modified 2015-12-14, has failed to recognize
the operating system you are using. It is advised that you
download the most up to date version of the config scripts from

  http://git.savannah.gnu.org/gitweb/?p=config.git;a=blob_plain;f=config.guess;hb=HEAD
and
  http://git.savannah.gnu.org/gitweb/?p=config.git;a=blob_plain;f=config.sub;hb=HEAD

If the version you run (./config.guess) is already up to date, please
send the following data and any information you think might be
pertinent to <config-patches@gnu.org> in order to provide the needed
information to handle your system.

config.guess timestamp = 2015-12-14

uname -m = riscv64
uname -r = 6.5.0-1021-azure
uname -s = Linux
uname -v = #22~22.04.1-Ubuntu SMP Tue Apr 30 16:08:18 UTC 2024

/usr/bin/uname -p = 
/bin/uname -X     = 

hostinfo               = 
/bin/universe          = 
/usr/bin/arch -k       = 
/bin/arch              = riscv64
/usr/bin/oslevel       = 
/usr/convex/getsysinfo = 

UNAME_MACHINE = riscv64
UNAME_RELEASE = 6.5.0-1021-azure
UNAME_SYSTEM  = Linux
UNAME_VERSION = #22~22.04.1-Ubuntu SMP Tue Apr 30 16:08:18 UTC 2024
configure: error: cannot guess build type; you must specify one
[…]

robert-scheck added a commit to rpki-client/rpki-client-container that referenced this pull request May 25, 2024
@botovq
Copy link
Member

botovq commented Jun 7, 2024

Sorry for the delay - I was hoping to see the autoconf 2.72 update (finally) land in OpenBSD and test with that, but that didn't yet happen...

The files you suggest to merge don't match what was shipped in the 2.72 tarballs, but I don't think it matters a lot. I have checked that they match what's in the git repo. The diff is the usual unreviewable autoconf noise randomly adding and removing quotes to lines and using relative or full paths for other things.

As far as I'm concerned this can be merged (or I'll do it sometime next week unless there are objectons).

@cjeker
Copy link
Member

cjeker commented Jun 7, 2024 via email

@botovq botovq merged commit e11740d into rpki-client:master Jun 7, 2024
6 checks passed
@robert-scheck
Copy link
Contributor Author

The files you suggest to merge don't match what was shipped in the 2.72 tarballs […]

Oh dear…it seems it was too much expectation that the commit from the v2.72 tag matches the upstream release tarball.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants