Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rails versions to CI matrix #125

Merged
merged 3 commits into from
Sep 21, 2024
Merged

Conversation

padde
Copy link
Contributor

@padde padde commented Sep 11, 2024

As suggested, here's my proposal to test against multiple Rails versions in the CI matrix. The new config will effectively run the tests against the following versions:

Workflow ruby rails grape-swagger
Tests 2.7 6.1.7 1.6.1
Tests 3.0 6.1.7 1.6.1
Tests 3.1 6.1.7 1.6.1
Tests 3.1 6.1.7 2.0.2
Tests 3.1 7.2.1 1.6.1
Tests 3.1 7.2.1 2.0.2
Tests 3.2 6.1.7 1.6.1
Tests 3.2 6.1.7 2.0.2
Tests 3.2 7.2.1 1.6.1
Tests 3.2 7.2.1 2.0.2
Tests jruby-9.4.6 6.1.7 1.6.1
Tests jruby-9.4.6 6.1.7 2.0.2
Tests jruby-9.4.6 7.2.1 1.6.1
Tests jruby-9.4.6 7.2.1 2.0.2
Tests (HEAD) 3.2 edge HEAD
Tests (HEAD) jruby-head edge HEAD
Tests (HEAD) ruby-head edge HEAD

Blockers

@padde padde mentioned this pull request Sep 11, 2024
1 task
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Close!

@padde
Copy link
Contributor Author

padde commented Sep 15, 2024

@dblock please check out my changes. I think the CI matrix config is fine, however some new test failures seem to be popping up that I haven't seen in the last runs, specifically with grape-swagger v2.0.2. Seems unrelated to the changes in this PR and confirmed that the old CI setup on master also fails for all grape-swagger v2.0.2 versions.

There are warnings about geckodriver being incompatible with the effectively used Firefox version 130.0 (although 111.0.1 is being requested) - I'll see if I can bump those to the current versions to fix the tests.

Update: the Firefox/geckodriver versions have nothing to do with the failures, probably still a good idea to stay up to date there. See #127

Update: the issues seem to be related to the latest grape release 2.2.0 which has removed Grape::ContentTypes::CONTENT_TYPES and is now incompatible with the latest grape-swagger release 2.1.0 , which still references this constant. See ruby-grape/grape-swagger#939

@dblock
Copy link
Member

dblock commented Sep 17, 2024

Let's get ruby-grape/grape-swagger#939 in and then we can test HEAD here with HEAD of that project too and get it all to green?

@padde
Copy link
Contributor Author

padde commented Sep 21, 2024

@dblock can you please trigger a re-run on CI here? Everything should now turn green after the grape-swagger 2.1.1 release

I don’t have the necessary permissions to do it.

@padde
Copy link
Contributor Author

padde commented Sep 21, 2024

@dblock never mind, force push does the trick as well 😉

HEAD is green, we just need to bump grape-swagger to 2.1.1 so it starts working again with the grape 2.2.0 (bundler automatically selected latest version).

@dblock dblock merged commit 30ab24f into ruby-grape:master Sep 21, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants