-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rails versions to CI matrix #125
Conversation
2ec60d7
to
24f9c2f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Close!
24f9c2f
to
101abf2
Compare
101abf2
to
0b06a7c
Compare
@dblock please check out my changes. I think the CI matrix config is fine, however some new test failures seem to be popping up that I haven't seen in the last runs, specifically with grape-swagger v2.0.2. Seems unrelated to the changes in this PR and confirmed that the old CI setup on master also fails for all grape-swagger v2.0.2 versions. There are warnings about geckodriver being incompatible with the effectively used Firefox version 130.0 (although 111.0.1 is being requested) - I'll see if I can bump those to the current versions to fix the tests. Update: the Firefox/geckodriver versions have nothing to do with the failures, probably still a good idea to stay up to date there. See #127 Update: the issues seem to be related to the latest |
Let's get ruby-grape/grape-swagger#939 in and then we can test HEAD here with HEAD of that project too and get it all to green? |
@dblock can you please trigger a re-run on CI here? Everything should now turn green after the grape-swagger 2.1.1 release I don’t have the necessary permissions to do it. |
0b06a7c
to
47b574b
Compare
@dblock never mind, force push does the trick as well 😉 HEAD is green, we just need to bump grape-swagger to 2.1.1 so it starts working again with the grape 2.2.0 (bundler automatically selected latest version). |
As suggested, here's my proposal to test against multiple Rails versions in the CI matrix. The new config will effectively run the tests against the following versions:
Blockers
Fixes CI