-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump rbs from v3.6.0 to v3.7.0 and steep from v1.8.0 to v1.8.1 #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is it possible to use inline type annotation for |
yui-knk
reviewed
Dec 15, 2024
``` lib/lrama/grammar/parameterizing_rule/rhs.rb:19:23: [warning] Empty hash doesn't have type annotation │ Diagnostic ID: Ruby::UnannotatedEmptyCollection │ └ var_to_arg = {} ~~ ```
``` lib/lrama/bitmap.rb:16:10: [warning] Empty array doesn't have type annotation │ Diagnostic ID: Ruby::UnannotatedEmptyCollection │ └ a = [] ~~ ```
``` lib/lrama/grammar/rule_builder.rb:70:28: [warning] Empty array doesn't have type annotation │ Diagnostic ID: Ruby::UnannotatedEmptyCollection │ └ resolved_builders = [] ~~ ```
``` lib/lrama/lexer/token/user_code.rb:19:23: [warning] Empty array doesn't have type annotation │ Diagnostic ID: Ruby::UnannotatedEmptyCollection │ └ references = [] ~~ ```
``` lib/lrama/grammar.rb:385:15: [warning] Empty array doesn't have type annotation │ Diagnostic ID: Ruby::UnannotatedEmptyCollection │ └ errors = [] ~~ ```
ydah
force-pushed
the
bump-rbs-and-steep
branch
from
December 15, 2024 01:35
1507cf9
to
a48c27d
Compare
ydah
force-pushed
the
bump-rbs-and-steep
branch
from
December 16, 2024 05:22
03e060a
to
12516fa
Compare
yui-knk
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following warnings and errors have been fixed as a result of the version update: